Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pre check is done for existence of same component in the cluster #2379

Closed
amitkrout opened this issue Nov 8, 2019 · 4 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/unresolved Indicates an issue that can not or will not be resolved.

Comments

@amitkrout
Copy link
Contributor

amitkrout commented Nov 8, 2019

/kind bug

What versions of software are you using?

Operating System:
supported
Output of odo version:
master

How did you run odo exactly?

$ odo create nodejs backend --context
 /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/ 
--project test123
$ odo push --context /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/
$ odo component list --context
  /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/
APP     NAME        TYPE       SOURCE        STATE
app     backend     nodejs     file://./     Pushed           -------------- Looks good

$ odo create python backend --context 
/Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/ 
--project test123
$ odo push --context /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/python/

$ odo component list --context  /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs/
APP     NAME        TYPE       SOURCE        STATE
app     backend     python     file://./     Pushed  <----- nodejs component is replaced 

$ odo component list --context  /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/python/
APP     NAME        TYPE       SOURCE        STATE
app     backend     python     file://./     Pushed  <----- nodejs component is replaced

Actual behavior

Replacing the deployed component of same name

Expected behavior

Should throw error of something like
There is already a component of same name exist in the same app and in same namespace.

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 8, 2019
@amitkrout
Copy link
Contributor Author

/priority high

@openshift-ci-robot openshift-ci-robot added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Nov 8, 2019
@kadel
Copy link
Member

kadel commented Nov 8, 2019

I'm afraid that with the current architecture this is impossible to solve.

If you push component with the same name and with the same application to the same project it will get replaced.

@kadel
Copy link
Member

kadel commented Dec 9, 2019

/triage unresolved
/close

@openshift-ci-robot openshift-ci-robot added the triage/unresolved Indicates an issue that can not or will not be resolved. label Dec 9, 2019
@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/triage unresolved
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). triage/unresolved Indicates an issue that can not or will not be resolved.
Projects
None yet
Development

No branches or pull requests

3 participants