Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package github.com/Netflix/go-expect affecting some unit tests on Windows #2586

Closed
prietyc123 opened this issue Feb 10, 2020 · 4 comments
Closed
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.
Projects

Comments

@prietyc123
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System: windows 10

Output of odo version: master

How did you run odo exactly?

make test on windows

Actual behavior

Some unit tests are failing.

Expected behavior

make test should pass successfully

Any logs, error output, etc?

Ref : https://travis-ci.com/openshift/odo/jobs/284808147

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2020
@kadel
Copy link
Member

kadel commented Feb 13, 2020

/area testing

@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Feb 13, 2020
@amitkrout
Copy link
Contributor

amitkrout commented Feb 16, 2020

@prietyc123 checkout - #2562 (comment) to get more idea on how to fix it.

@prietyc123 prietyc123 changed the title Some Unit tests are not supporting Windows Package github.com/Netflix/go-expect affecting some Unit tests on Windows Mar 4, 2020
@prietyc123 prietyc123 changed the title Package github.com/Netflix/go-expect affecting some Unit tests on Windows Package github.com/Netflix/go-expect affecting some unit tests on Windows Mar 4, 2020
@prietyc123 prietyc123 assigned mik-dass and unassigned mik-dass Mar 4, 2020
@girishramnani girishramnani added this to For consideration in Sprint 181 via automation Mar 9, 2020
@prietyc123
Copy link
Contributor Author

prietyc123 commented Mar 19, 2020

We have similar created issue #2630

/close

@openshift-ci-robot
Copy link
Collaborator

@prietyc123: Closing this issue.

In response to this:

#2630 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sprint 181 automation moved this from For consideration to Done Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering kind/bug Categorizes issue or PR as related to a bug.
Projects
No open projects
Sprint 181
  
Done
Development

No branches or pull requests

5 participants