Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration test suites for devfile support #2673

Closed
3 tasks
johnmcollier opened this issue Mar 3, 2020 · 7 comments
Closed
3 tasks

Create integration test suites for devfile support #2673

johnmcollier opened this issue Mar 3, 2020 · 7 comments
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.
Projects

Comments

@johnmcollier
Copy link
Member

johnmcollier commented Mar 3, 2020

Currently there's no integration test suites for the devfile support in odo. While this isn't much of an issue right now, when there isn't much in terms of devfile support (at this moment, just creating a deployment), as we add more features and as the devfile-mode becomes more complete, this will become a bigger and bigger issue. Additionally, adding integration tests for devfile support will require more work the longer that we delay it (as more and more functionality needs to be tested).

So, we should create integration test suites for odo's devfile support sooner rather than later.

  • Create new test suites under tests/integration for the devfile/experimental features in odo
    • Need to add some sample devfiles and projects under tests/examples
  • Get the integration tests running in Travis
    • Update the makefile with the new test suites
    • Update the .travis.yml to run those tests
  • Get the integration tests running in OpenShift CI
    • @kadel What needs to be done for this step? For Travis it's pretty clear, but I'm not sure how/where to tell the OpenShift CI which tests to run.

/area testing
/area devfile

@openshift-ci-robot
Copy link
Collaborator

@johnmcollier: The label(s) area/devfiles cannot be applied, because the repository doesn't have them

In response to this:

Currently there's no integration tests for the devfile support in odo. While this isn't much of an issue right now, when there isn't much in terms of devfile support (at this moment, just creating a deployment), as we add more features and as the devfile-mode becomes more complete, this will become a bigger and bigger issue. Additionally, adding integration tests for devfile support will require more work the longer that we delay it (as more and more functionality needs to be tested).

So, we should create integration test suites for odo's devfile support sooner rather than later.

  • Create new test suites under tests/integration for the devfile/experimental features in odo
    • Need to add some sample devfiles and projects under tests/examples
  • Get the integration tests running in Travis
    • Update the makefile with the new test suites
    • Update the .travis.yml to run those tests
  • Get the integration tests running in OpenShift CI
    • @kadel What needs to be done for this step? For Travis it's pretty clear, but I'm not sure how/where to tell the OpenShift CI which tests to run.

/area testing
/area devfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Mar 3, 2020
@johnmcollier johnmcollier changed the title Create integration tests for devfile support Create integration test suites for devfile support Mar 3, 2020
@openshift-ci-robot
Copy link
Collaborator

@johnmcollier: The label(s) area/devfiles cannot be applied, because the repository doesn't have them

In response to this:

Currently there's no integration tests for the devfile support in odo. While this isn't much of an issue right now, when there isn't much in terms of devfile support (at this moment, just creating a deployment), as we add more features and as the devfile-mode becomes more complete, this will become a bigger and bigger issue. Additionally, adding integration tests for devfile support will require more work the longer that we delay it (as more and more functionality needs to be tested).

So, we should create integration test suites for odo's devfile support sooner rather than later.

  • Create new test suites under tests/integration for the devfile/experimental features in odo
    • Need to add some sample devfiles and projects under tests/examples
  • Get the integration tests running in Travis
    • Update the makefile with the new test suites
    • Update the .travis.yml to run those tests
  • Get the integration tests running in OpenShift CI
    • @kadel What needs to be done for this step? For Travis it's pretty clear, but I'm not sure how/where to tell the OpenShift CI which tests to run.

/area testing
/area devfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Collaborator

@johnmcollier: The label(s) area/devfiles cannot be applied, because the repository doesn't have them

In response to this:

Currently there's no integration test suites for the devfile support in odo. While this isn't much of an issue right now, when there isn't much in terms of devfile support (at this moment, just creating a deployment), as we add more features and as the devfile-mode becomes more complete, this will become a bigger and bigger issue. Additionally, adding integration tests for devfile support will require more work the longer that we delay it (as more and more functionality needs to be tested).

So, we should create integration test suites for odo's devfile support sooner rather than later.

  • Create new test suites under tests/integration for the devfile/experimental features in odo
    • Need to add some sample devfiles and projects under tests/examples
  • Get the integration tests running in Travis
    • Update the makefile with the new test suites
    • Update the .travis.yml to run those tests
  • Get the integration tests running in OpenShift CI
    • @kadel What needs to be done for this step? For Travis it's pretty clear, but I'm not sure how/where to tell the OpenShift CI which tests to run.

/area testing
/area devfiles

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Mar 4, 2020
@johnmcollier
Copy link
Member Author

johnmcollier commented Mar 5, 2020

I took a crack at writing integration test suites for devfiles (mostly just odo push and syncing) and hit #2684 as a blocker.

@johnmcollier
Copy link
Member Author

My sync PR does the following:

Once my sync PR has been delivered, this issue can be closed out.

@johnmcollier
Copy link
Member Author

/assign

@elsony elsony added this to For consideration in Sprint 180 via automation Mar 6, 2020
@elsony elsony moved this from For consideration to In progress in Sprint 180 Mar 6, 2020
@elsony elsony added this to For consideration in Sprint 181 via automation Mar 10, 2020
@elsony elsony moved this from For consideration to In progress in Sprint 181 Mar 10, 2020
@girishramnani girishramnani removed this from In progress in Sprint 180 Mar 11, 2020
@girishramnani girishramnani added kind/test and removed area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering labels Mar 11, 2020
@johnmcollier
Copy link
Member Author

This can be closed out - looks like my PR didn't close it when it was merged

Sprint 181 automation moved this from In progress to Done Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.
Projects
No open projects
Sprint 181
  
Done
Development

No branches or pull requests

3 participants