Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No spinner on wait for deployment rollout #2827

Closed
johnmcollier opened this issue Apr 6, 2020 · 0 comments · Fixed by #2915
Closed

No spinner on wait for deployment rollout #2827

johnmcollier opened this issue Apr 6, 2020 · 0 comments · Fixed by #2915
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug.

Comments

@johnmcollier
Copy link
Member

/kind bug

What versions of software are you using?

Operating System:
macOS

Output of odo version:
master

How did you run odo exactly?

When odo waits for the deployment rollout as part of odo push, a spinner doesn't get created, so the user just sees this while they wait for the Deployment to finish rolling out:

Johns-MacBook-Pro-3:openLiberty johncollier$ odo push
 •  Push devfile component openliberty  ...

rather than

Johns-MacBook-Pro-3:openLiberty johncollier$ odo push
 •  Push devfile component openliberty  ...
 ◒  Waiting for devfile component openliberty to rollout ...

Additionally, when the deployment rollout is finished, it doesn't tell the user how long the command took to run:

Johns-MacBook-Pro-3:openLiberty johncollier$ odo push
 •  Push devfile component openliberty  ...
 ✓  Checking files for pushing [7ms]
 ✓  Waiting for component to start [80ms]
 ✓  Syncing files to the component [2s]
 ✓  Executing devbuild command /artifacts/bin/build.sh [1m]
 ✓  Executing devrun command /artifacts/bin/run.sh [2s]
 ✓  Push devfile component openliberty [1m]
 ✓  Changes successfully pushed to component

The WaitAndGetPod function in kclient uses a spinner (as you can see above with the Waiting for component to start line), but I think WaitForDeploymentRollout should have it too.

/area devfile

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants