[Devfile] Add a spinner for deployment rollout #2915
Conversation
Signed-off-by: John Collier <John.J.Collier@ibm.com>
openshift-ci-robot
added
kind/bug
| @@ -86,7 +86,7 @@ func (a Adapter) Push(parameters common.PushParameters) (err error) { | |||
| } | |||
|
|
|||
| // Wait for Pod to be in running state otherwise we can't sync data or exec commands to it. | |||
| pod, err := a.waitAndGetComponentPod(false) | |||
| pod, err := a.waitAndGetComponentPod(true) | |||
There was a problem hiding this comment.
We set hideSpinner to true here, that means we don't need the spinner for waiting pods?
There was a problem hiding this comment.
The spinner is not necessary here, we're just using that to retrieve the pod. The actually waiting for the component to start is in the Rollout function.
|
The changes look good to me, just leave a comment above |
openshift-ci-robot
added
the
lgtm
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2915 +/- ##
==========================================
+ Coverage 43.70% 43.71% +0.01%
==========================================
Files 102 102
Lines 9160 9163 +3
==========================================
+ Hits 4003 4006 +3
- Misses 4780 4781 +1
+ Partials 377 376 -1
Continue to review full report at Codecov.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: John Collier John.J.Collier@ibm.com
What type of PR is this?
/kind bug
/area devfile
What does does this PR do / why we need it:
This PR adds a spinner to the
WaitForDeploymentRolloutfunction in kclient. Previously, since there was no spinner, the user would be looking atWhile they waited for the component to rollout. Now they will see:
and
Which issue(s) this PR fixes:
Fixes #2827
How to test changes / Special notes to the reviewer:
Run
odo pushwith a devfile, and verify that the spinner shows up while the deployment rolls out