Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odo push failing for devfile with invalid container name #2859

Closed
adisky opened this issue Apr 9, 2020 · 2 comments
Closed

odo push failing for devfile with invalid container name #2859

adisky opened this issue Apr 9, 2020 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@adisky
Copy link
Contributor

adisky commented Apr 9, 2020

/kind bug

we are passing *action.Component here at the place of container name
https://github.com/openshift/odo/blob/04c5e50957482a2014125bde64783f326d25f5e2/pkg/devfile/adapters/kubernetes/component/adapter.go#L457

As i could check from devfile.yaml, component is tools here, which is taken as container name
https://github.com/elsony/devfile-registry/blob/master/devfiles/maven/devfile.yaml#L20

[adisky@localhost quarkus-quickstarts]$ odo push -f 
 •  Push devfile component my  ...
 ✓  Waiting for component to start [6ms]
 ✓  Syncing files to the component [10s]
 ✗  Executing devbuild command mvn package [9ms]
 ✗  Failed to start component with name my.
Error: Failed to create the component: error while streaming command: container tools is not valid for pod my-56d5f8fd6b-hqgc5
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2020
@adisky
Copy link
Contributor Author

adisky commented Apr 13, 2020

/close

@openshift-ci-robot
Copy link
Collaborator

@adisky: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants