Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific working directory defined in the command #2937

Closed
1 task
elsony opened this issue Apr 20, 2020 · 9 comments
Closed
1 task

Specific working directory defined in the command #2937

elsony opened this issue Apr 20, 2020 · 9 comments
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) triage/needs-information Indicates an issue needs more information in order to work on it.
Projects

Comments

@elsony
Copy link

elsony commented Apr 20, 2020

/kind user-story

User Story

As a stack creator, I want to specify the working directory in a command in the devfile so that the command is executed in the given working directory in the container.

Acceptance Criteria

Links

/kind user-story
/area devfile

@openshift-ci-robot openshift-ci-robot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. labels Apr 20, 2020
@elsony elsony added this to For consideration in Sprint 183 via automation Apr 20, 2020
@kadel
Copy link
Member

kadel commented Apr 22, 2020

/status blocked
we need to have a parser implementation first #2918

@kadel kadel added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Apr 22, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 183 Apr 23, 2020
@elsony elsony added this to For consideration in Sprint 184 via automation May 8, 2020
@elsony elsony removed this from To do in Sprint 183 May 8, 2020
@girishramnani girishramnani added devfileV2 triage/needs-information Indicates an issue needs more information in order to work on it. labels May 11, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 184 May 14, 2020
@elsony elsony moved this from To do to In progress in Sprint 184 May 26, 2020
@maysunfaisal
Copy link
Contributor

This seems to be covered by PR #3216

@yangcao77 yangcao77 mentioned this issue May 28, 2020
@yangcao77
Copy link
Contributor

This issue should be closed. It's covered by #3194

@elsony
Copy link
Author

elsony commented May 28, 2020

Item completed

@elsony elsony closed this as completed May 28, 2020
Sprint 184 automation moved this from In progress to Done May 28, 2020
@elsony
Copy link
Author

elsony commented May 28, 2020

Reopen since it turns out the code is on parser-v2 branch but not master.

@elsony elsony reopened this May 28, 2020
@elsony elsony moved this from Done to For review in Sprint 184 May 28, 2020
@girishramnani girishramnani added this to For consideration in Sprint 185 via automation Jun 1, 2020
@girishramnani girishramnani removed this from For review in Sprint 184 Jun 1, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 185 Jun 1, 2020
@yangcao77
Copy link
Contributor

commands:
 - exec:
     commandLine: "./buildSchema.sh"
     workingDir: "~/schemaScripts"
     component: build-tools
     alias: buildSchema

Devfile v2 have the workingDir defined under commands.exec. Any commandLine provided will be run under the workingDir defined.

cmdArr = []string{adaptersCommon.ShellExecutable, "-c", "cd " + exec.WorkingDir  + " && " + *action.Command}

@yangcao77
Copy link
Contributor

/triage cancel

Verified on both Kube and Docker with master branch, commands can be run under the workingDir provided.

Since the parser v2 branch has been merged in to master. This item can be safely closed.

@openshift-ci-robot
Copy link
Collaborator

@yangcao77: The label(s) triage/cancel cannot be applied, because the repository doesn't have them

In response to this:

/triage cancel

Verified on both Kube and Docker with master branch, commands can be run under the workingDir provided.

Since the parser v2 branch has been merged in to master. This item can be safely closed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elsony
Copy link
Author

elsony commented Jun 9, 2020

Code merged. Closing.

@elsony elsony closed this as completed Jun 9, 2020
Sprint 185 automation moved this from For review to Done Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
No open projects
Sprint 185
  
Done
Development

No branches or pull requests

6 participants