Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For secured url1 'odo url describe url1 -o json' prints 'secure' attribute as false #3060

Closed
dgolovin opened this issue May 1, 2020 · 4 comments · Fixed by #3160 or #3269
Closed
Assignees
Labels
area/json-output Issues or PRs related to JSON output (machine readable output) kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo
Projects

Comments

@dgolovin
Copy link
Contributor

dgolovin commented May 1, 2020

/kind bug

What versions of software are you using?

Operating System:
windows 10
Output of odo version:
1.2.0

How did you run odo exactly?

Component has one secured url.
Running:
odo url describe
odo url list
show the same url with different values for 'secure' attribute.

Actual behavior

denis@denis-ThinkPad-P50:~/test/test-1$ odo url describe url1 -o json
{
    "kind": "url",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {
        "name": "url1",
        "creationTimestamp": null
    },
    "spec": {
        "port": 8080,
        "secure": false
    },
    "status": {
        "state": "Pushed"
    }
}

odo ulr list prints out different json with correct value.

denis@denis-ThinkPad-P50:~/test/test-1$ odo url list -o json
{
    "kind": "List",
    "apiVersion": "odo.openshift.io/v1alpha1",
    "metadata": {},
    "items": [
        {
            "kind": "url",
            "apiVersion": "odo.openshift.io/v1alpha1",
            "metadata": {
                "name": "url3",
                "creationTimestamp": null
            },
            "spec": {
                "host": "url3-app1-p1.apps-crc.testing",
                "protocol": "https",
                "port": 8080,
                "secure": true
            },
            "status": {
                "state": "Pushed"
            }
        }
    ]
}

Expected behavior

In both outputs secure equals true

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 1, 2020
@dharmit dharmit added area/url priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels May 4, 2020
@girishramnani girishramnani added the area/json-output Issues or PRs related to JSON output (machine readable output) label May 11, 2020
@girishramnani girishramnani added this to For consideration in Sprint 184 via automation May 11, 2020
@jeffmaury
Copy link
Member

Adding to this use case: if url is created with secure attribute but not pushed to the cluster, then odo url list reports it as non secure. After the url is pushed to the cluster then odo url list is correct.

@jeffmaury
Copy link
Member

Also please note that the URL is not retrieved by odo url describe

@girishramnani girishramnani moved this from For consideration to To do in Sprint 184 May 14, 2020
@yangcao77
Copy link
Contributor

yangcao77 commented May 28, 2020

For ingress URLs(for devfile component), should be fixed via: #3160
/assign

@elsony elsony moved this from To do to For review in Sprint 184 May 28, 2020
@girishramnani girishramnani removed this from For review in Sprint 184 Jun 1, 2020
@girishramnani girishramnani added this to For consideration in Sprint 185 via automation Jun 1, 2020
@girishramnani girishramnani moved this from For consideration to For review in Sprint 185 Jun 1, 2020
Sprint 185 automation moved this from For review to Done Jun 1, 2020
@mik-dass
Copy link
Contributor

mik-dass commented Jun 1, 2020

#3269 needs to be merged for URL of route kind

@mik-dass mik-dass reopened this Jun 1, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/json-output Issues or PRs related to JSON output (machine readable output) kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Sprint 185
  
Done
8 participants