Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL describe under experimental mode should work for both routes and ingresses #3182

Closed
yangcao77 opened this issue May 14, 2020 · 6 comments · Fixed by #3305
Closed

URL describe under experimental mode should work for both routes and ingresses #3182

yangcao77 opened this issue May 14, 2020 · 6 comments · Fixed by #3305
Assignees
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented May 14, 2020

/kind bug

This bug is due to the new change for adding support for routes under experimental mode.
The current logic for list and describe only search for ingresses if experimental mode is turned on. An expected bug, need to modify the logic.

How did you run odo exactly?

With experimental mode set, create a route UR
Run url describe <route url>

Actual behavior

url describe <route url> complains the URL does not exist

Expected behavior

url describe should be able to look for routes as well in experimental mode

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 14, 2020
@yangcao77
Copy link
Contributor Author

/area url
/assign

@johnmcollier
Copy link
Member

@yangcao77 I think this is the same issue as #2985?

@elsony elsony added this to For consideration in Sprint 184 via automation May 14, 2020
@elsony elsony moved this from For consideration to To do in Sprint 184 May 14, 2020
@yangcao77
Copy link
Contributor Author

@johnmcollier Yes. #2985 is part of this issue, the issue should also include the change for odo describe

@yangcao77
Copy link
Contributor Author

Actually I will convert this issue for url describe only. So we have separate issues for these two different commands.

@yangcao77 yangcao77 changed the title URL list/describe under experimental mode should work for both routes and ingresses URL describe under experimental mode should work for both routes and ingresses May 14, 2020
@yangcao77
Copy link
Contributor Author

yangcao77 commented May 26, 2020

Blocked by: #3160
/status blocked

@mik-dass mik-dass added kind/bug Categorizes issue or PR as related to a bug. status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) and removed kind/bug Categorizes issue or PR as related to a bug. labels May 27, 2020
@girishramnani girishramnani added this to For consideration in Sprint 185 via automation Jun 1, 2020
@girishramnani girishramnani removed this from To do in Sprint 184 Jun 1, 2020
@girishramnani girishramnani moved this from For consideration to To do in Sprint 185 Jun 1, 2020
@elsony elsony moved this from To do to In progress in Sprint 185 Jun 2, 2020
@elsony elsony removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Jun 2, 2020
@yangcao77
Copy link
Contributor Author

/area devfile
Adding devfile label since it's for experimental mode. but it's not restricted to devfile component.

@openshift-ci-robot openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Jun 2, 2020
@elsony elsony moved this from In progress to For review in Sprint 185 Jun 9, 2020
Sprint 185 automation moved this from For review to Done Jun 17, 2020
@rm3l rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. v2 Issue or PR that applies to the v2 of odo
Projects
Archived in project
Sprint 185
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants