Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional flag --log_file along with odo subcommand doesn't work #3444

Closed
amitkrout opened this issue Jun 30, 2020 · 4 comments
Closed

Additional flag --log_file along with odo subcommand doesn't work #3444

amitkrout opened this issue Jun 30, 2020 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great. triage/duplicate Indicates an issue or PR that is a duplicate of other open issue or PR.

Comments

@amitkrout
Copy link
Contributor

amitkrout commented Jun 30, 2020

/kind bug

What versions of software are you using?

Operating System:
supported
Output of odo version:
master

How did you run odo exactly?

$ odo project create test123

$ oc --request-timeout 5m import-image nodejs --namespace=test123 --from=registry.access.redhat.com/rhscl/nodejs-10-rhel7:latest --confirm

$ oc annotate istag/nodejs:latest --namespace=test123 tags=builder --overwrite

$ odo create nodejs nodejs-app --project test123 --context tests/examples/source/nodejs/

$ odo push --context tests/examples/source/nodejs/

// open another terminal. Then run command
$ odo watch --context tests/examples/source/nodejs/ --log_file <logfile_path>

// create a file or dir in the context dir 

Actual behavior

No log file is generated in the specified path

$ tree -a -v /Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
/Users/amit/go/src/github.com/openshift/odo/tests/examples/source/nodejs
├── .gitignore
├── .odo
│   ├── config.yaml
│   └── odo-file-index.json
├── check.sh
├── package.json
└── server.js

1 directory, 6 files

Expected behavior

Should create log file as per the UX description

$ odo watch -h
[...]
Flags:
      [...]
Additional Flags:
      [...]
      --log_file string          If non-empty, use this log file
      [...]

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 30, 2020
@amitkrout
Copy link
Contributor Author

The same additional flags are also available for other sub commands too. I checked --log_file with preference command and it doesn't generate log file in the specified path.

I am changing the issue title to a generic one.

@amitkrout amitkrout changed the title Additional flag --log_file along with watch command doesn't work Additional flag --log_file along with odo subcommand doesn't work Jun 30, 2020
@amitkrout amitkrout added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). area/component labels Jun 30, 2020
@girishramnani
Copy link
Contributor

This doesn't seem like high priority to me. Any reason to put high priority
/remove-priority high
/priority medium

@openshift-ci-robot openshift-ci-robot added priority/Medium Nice to have issue. Getting it done before priority changes would be great. and removed priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). labels Jun 30, 2020
@kadel
Copy link
Member

kadel commented Jun 30, 2020

/triage duplicate
/close

This is related to
#3446

@openshift-ci-robot openshift-ci-robot added the triage/duplicate Indicates an issue or PR that is a duplicate of other open issue or PR. label Jun 30, 2020
@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/triage duplicate
/close

This is related to
#3446

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/Medium Nice to have issue. Getting it done before priority changes would be great. triage/duplicate Indicates an issue or PR that is a duplicate of other open issue or PR.
Projects
None yet
Development

No branches or pull requests

4 participants