odo create --devfile ./devfile.yaml deletes current devfile

[kadel]

If I run odo create with --devfile flag that points to the devfile in current directory odo just replaces it with empty file :-( Which is pretty ugly, as it just destroyed my work :-(

The reason I would like to be able to run with --devfile devfile.yaml is that I want for odo to use my already existing devfile and also be able to provide custom odo component name.

▶ odo create frontend --devfile devfile.yaml
Experimental mode is enabled, use at your own risk

Validation
 ✓  Creating a devfile component from devfile path: /Users/tkral/tmp/odo-examples/demo-frontend/devfile.yaml [90653ns]
 ✓  Validating devfile component [134579ns]

Please use `odo push` command to create the component with source deployed

▶ cat devfile.yaml

Correct behavior should be to just keep my current devfile.yaml untouched.

/kind bug
/area devfile
/area component
/priority high

[openshift-ci-robot]

@kadel: The label(s) area/create cannot be applied, because the repository doesn't have them

In response to this:

If I run odo create with --devfile flag that points to the devfile in current directory odo just replaces it with empty file :-( Which is pretty ugly, as it just destroyed my work :-(

The reason I would like to be able to run with --devfile devfile.yaml is that I want for odo to use my already existing devfile and also be able to provide custom odo component name.

▶ odo create frontend --devfile devfile.yaml
Experimental mode is enabled, use at your own risk

Validation
✓  Creating a devfile component from devfile path: /Users/tkral/tmp/odo-examples/demo-frontend/devfile.yaml [90653ns]
✓  Validating devfile component [134579ns]

Please use `odo push` command to create the component with source deployed

▶ cat devfile.yaml

/kind bug
/area devfile
/area create
/priority high

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[GeekArthur]

Duplicate of #3452.

Temporary workaround:
You can run odo create in the current directory directly without using --devfile flag then odo can pick up the existing devfile in the current directory.

Permanent fix:
To fix this, we can just add validation code at the beginning of the file copy function https://github.com/openshift/odo/blob/master/pkg/util/util.go#L1081 to return the function directly if source and destination paths are the same.

I believe the problem is that since we don't catch this edge case in the file copy function, then os.Create() and os.Open() conflicts with each other so that generating an empty devfile.

[adisky]

since #3452 and this one similar we should close one.