Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two devfile component deployed with same name, second component overrides the first one. #3579

Closed
adisky opened this issue Jul 15, 2020 · 5 comments
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.

Comments

@adisky
Copy link
Contributor

adisky commented Jul 15, 2020

/kind discussion

What versions of software are you using?

Operating System:

Output of odo version:

How did you run odo exactly?

Actual behavior

If you try two create two devfile component with same, neither odo push nor odo create gives error.
e.g

  • create a nodejs component
    $ odo create nodejs unique
    $ odo push
  • create a springboot component with same name from a different dir
    $ odo create springboot unique
    $ odo push

odo push succeeds here, with springboot component overridden the nodejs component.

Expected behavior

odo create should give error, if the devfile component with same name already present on the cluster.

Any logs, error output, etc?

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 15, 2020
@adisky adisky added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Jul 15, 2020
@adisky adisky changed the title Two Devfile component deployed with same name, second component overrides the first one. Two devfile component deployed with same name, second component overrides the first one. Jul 15, 2020
@girishramnani
Copy link
Contributor

but this is a concious decision that you as a user are making, so isn't this acceptable?

@adisky
Copy link
Contributor Author

adisky commented Jul 22, 2020

i am not sure about the behavior here, but shouldn't odo create give error if you try to create component with same name?

@adisky adisky added area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. and removed area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/bug Categorizes issue or PR as related to a bug. labels Jul 22, 2020
@girishramnani
Copy link
Contributor

Yeah I suppose so

@adisky
Copy link
Contributor Author

adisky commented Jul 22, 2020

got your point we are doing same in s2i, I do not see any downside of existing behavior too.
/close

@openshift-ci-robot
Copy link
Collaborator

@adisky: Closing this issue.

In response to this:

got your point we are doing same in s2i, I did not found any harm with this behavior.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it.
Projects
None yet
Development

No branches or pull requests

3 participants