Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a more clear error message for odo login when authentication fails #978

Closed
jankleinert opened this issue Nov 14, 2018 · 4 comments
Closed

Comments

@jankleinert
Copy link
Contributor

[kind/Enhancement]

First of all, I'm very excited to see the new support for login and logout directly supported in odo!

When using odo login, if you enter an incorrect password, you get the following output:

challenger chose not to retry the request

It may not be clear to users that that message means login failed due to authorization issues. Could the message be clarified to be something more like what oc login displays, where it tells what went wrong and what to do to fix it?

example:

Login failed (401 Unauthorized)
Verify you have provided correct credentials.
@surajnarwade
Copy link
Contributor

surajnarwade commented Nov 16, 2018

@jankleinert , that is completely handled by openshift, we don't have control over it.

Bydway, challenger chose not to retry the request is being solved in #997

@surajnarwade
Copy link
Contributor

@jankleinert , can you please verify this issue & close if resolved ?

@kadel
Copy link
Member

kadel commented Dec 16, 2019

/close

@openshift-ci-robot
Copy link
Collaborator

@kadel: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants