Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes redundant check for existence of component #2440

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Removes redundant check for existence of component #2440

merged 1 commit into from
Dec 10, 2019

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Dec 9, 2019

What kind of PR is this?

/kind bug

What does does this PR do / why we need it:
This PR removes redundant if check.

Which issue(s) this PR fixes:
NA

How to test changes / Special notes to the reviewer:
Check for the CI's blessings.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2019
@dharmit dharmit requested a review from mik-dass December 9, 2019 10:26
@kadel
Copy link
Member

kadel commented Dec 9, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 9, 2019
@dharmit
Copy link
Member Author

dharmit commented Dec 10, 2019

#2088

Running odo with args [odo url create url-1 --context /tmp/618592510]
[odo]  ✗  invalid configuration: [context was not found for specified context: szpnjdeqws/api-ci-op-1bz85b0f-18180-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]
[odo] Please login to your server:

/test v4.2-integration-e2e-benchmark

mik-dass
mik-dass approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 10, 2019
@openshift-merge-robot openshift-merge-robot merged commit 382df18 into redhat-developer:master Dec 10, 2019
@dharmit dharmit deleted the remove-redundant-if-check branch December 10, 2019 09:49
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@cdrage cdrage Awaiting requested review from cdrage

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dharmit @kadel @openshift-ci-robot @mik-dass @rm3l @openshift-merge-robot