Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PROJECT field to 'odo list' output #2453

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Adds PROJECT field to 'odo list' output #2453

merged 1 commit into from
Dec 12, 2019

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Dec 12, 2019

What type of PR is this?
/kind feature

(Honestly not sure what the kind is here. Should it be enhancement?)

What does does this PR do / why we need it:
$Title

Which issue(s) this PR fixes:

Fixes #2219

How to test changes / Special notes to the reviewer:
Before:

$ odo list --path ~/src
APP     NAME         TYPE       SOURCE                      STATE          CONTEXT
app     backend      java       target/wildwest-1.0.jar     Pushed         /home/dshah/src/Wild-West-Backend
app     frontend     nodejs     ./                          Pushed         /home/dshah/src/Wild-West-Frontend
app     node         nodejs     ./                          Not Pushed     /home/dshah/src/nodejs-ex

Now:

$ odo list --path ~/src
APP     NAME         PROJECT        TYPE       SOURCE                      STATE          CONTEXT
app     backend      myproject      java       target/wildwest-1.0.jar     Pushed         /home/dshah/src/Wild-West-Backend
app     frontend     myproject      nodejs     ./                          Pushed         /home/dshah/src/Wild-West-Frontend
app     node         newproject     nodejs     ./                          Not Pushed     /home/dshah/src/nodejs-ex

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation size/XS labels Dec 12, 2019
@kadel
Copy link
Member

kadel commented Dec 12, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Dec 12, 2019
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 12, 2019
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e4510b9 into redhat-developer:master Dec 12, 2019
@dharmit dharmit deleted the fix-2219 branch December 16, 2019 09:12
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add PROJECT column to odo component list output
7 participants