Delete services belonging to an application during 'odo app delete' #2491

dharmit · 2019-12-31T08:27:43Z

What type of PR is this?

/kind bug

What does does this PR do / why we need it:
This PR deletes the service (ServiceInstance) created from Service Catalog when user tries to delete an application (odo app delete <app-name>).

When there are no components in the application but only service(s), it also prints the list of services that would be deleted when doing odo app delete <app-name>. This list of services was not getting printed unless there was a component in <app-name> marked for deletion.

Which issue(s) this PR fixes:

Fixes #2113

How to test changes / Special notes to the reviewer:

Create a service from Service Catalog odo service create
Make sure the service shows up in odo service list --app app
Now delete the app odo app delete app -f
Make sure that no services exist. (Check on OpenShift web console)

pkg/occlient/occlient.go

dharmit · 2020-01-02T07:58:13Z

[odo]  ✗  serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "lcnolchtql"

This error might show up when there are permission issue, but it also shows up when Service Catalog is not enabled in the cluster. I tried to delete the app on a minishift cluster that didn't have Service Catalog setup:

# Before enabling the Service Catalog
$ odo app delete app -f
This application has following components that will be deleted
component named node
No services / could not get services
 ✗  serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "myproject": no RBAC policy matched

$ odo service list --project myproject
 ✗  Service catalog is not enabled within your cluster: unable to list services: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "myproject": no RBAC policy matched

# After enabling the Service Catalog
$ odo app delete app -f
This application has following components that will be deleted
component named node
Deleted application: app from project: myproject

I remember having a conversation where the reason for not enabling Service Catalog in the tests was to keep the test cluster less beefy. Let me know what you recommend in this situation. @kadel @amitkrout

girishramnani · 2020-01-02T08:32:54Z

[odo]  ✗  serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "lcnolchtql"

This error might show up when there are permission issue, but it also shows up when Service Catalog is not enabled in the cluster. I tried to delete the app on a minishift cluster that didn't have Service Catalog setup:

# Before enabling the Service Catalog
$ odo app delete app -f
This application has following components that will be deleted
component named node
No services / could not get services
 ✗  serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "myproject": no RBAC policy matched

$ odo service list --project myproject
 ✗  Service catalog is not enabled within your cluster: unable to list services: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list serviceinstances.servicecatalog.k8s.io in the namespace "myproject": no RBAC policy matched

# After enabling the Service Catalog
$ odo app delete app -f
This application has following components that will be deleted
component named node
Deleted application: app from project: myproject

I remember having a conversation where the reason for not enabling Service Catalog in the tests was to keep the test cluster less beefy. Let me know what you recommend in this situation. @kadel @amitkrout

we shouldn't fail the deletion of app if the service catalog doesn't exist.

dharmit · 2020-01-02T09:38:29Z

pkg/application/application.go

+	svcList, err := service.List(client, name)
+	if err != nil {
+		// error is returned when there's no Service Catalog enabled in the service
+		glog.V(4).Infof("Service catalog is not enabled in the cluster, skipping service deletion")


I'm assuming this based on https://github.com/openshift/odo/blob/974de1fd1285ce8680e7597ba09cf17345e0504d/pkg/odo/cli/service/list.go#L59-L62 in which List function is one among more functions which are generalized by this log message

dharmit · 2020-01-02T11:37:06Z

we shouldn't fail the deletion of app if the service catalog doesn't exist.

Of course we shouldn't. And that's not what were doing. The problem was only in the CI. If you tried in your dev environment with an OpenShift cluster that doesn't have Service Catalog, it wouldn't have failed. It would have just exited silently and successfully!

Anyway, I get your point and I have made the changes by referring to other parts of the code base. Most CI checks look happy now. 🕺

girishramnani · 2020-01-03T06:37:14Z

/approve

openshift-ci-robot · 2020-01-03T06:37:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prietyc123 · 2020-01-03T08:37:14Z

pkg/occlient/occlient_test.go

@@ -1398,20 +1398,22 @@ func TestCreateServiceBinding(t *testing.T) {
 		name        string
 		bindingNS   string
 		bindingName string
+		labels      map[string]string
 		wantErr     bool
 	}{
 		{
 			name:        "Case: Valid request for creating a secret",


I think we should have some more test case for this unit test like we should have the test case for invalid request also. What will happen if we pass empty labels or different binding name other than foo. I think we should consider these test case also. It's just a thought, WDYT?

I looked at it as you suggested. But we're getting these values from the function that calls CreateServiceBinding. About the invalid request point, it's valid but CreateServiceBinding uses function in the OpenShift API to create the Service Binding. So adding a test for it would be futile (assuming the tests already exist in OpenShift source code.)

IMO we should also add some invalid test case to be safe. Depending on Openshift source code tests won't be good idea i guess. :-)

I think we should have some more test case for this unit test like we should have the test case for invalid request also. What will happen if we pass empty labels or different binding name other than foo. I think we should consider these test case also. It's just a thought, WDYT?

The function we are testing here just calls the openshift api server with the arguments passed to it. The cases that you have mentioned would have been already taken care of by openshift.

It's not about scope but actually who is responsible of the test. once the occlient handed over the data all the validation and functionality come under the scope of openshift. and so does testing those pieces.

pkg/occlient/occlient.go

dharmit · 2020-01-03T10:48:21Z

Breaks the test at:

--- FAIL: TestCreateServiceInstance/Create_service_instance (0.00s)
        occlient_test.go:2562:  client.CreateServiceInstance(serviceName,serviceType, labels) unexpected error unable to create the secret jenkins for the service instance: Found nil value for bindingName or namesapce; need values for both, wantErr false

girishramnani · 2020-01-03T11:06:16Z

namesapce

typo 🙂 @dharmit

dharmit · 2020-01-03T11:38:29Z

namesapce

typo slightly_smiling_face @dharmit

😂

I'm anyway considering taking back the check for bindingName and namesapce. Because it's causing a different test to fail. Also, in spite of empty value for bindingName in the unit tests, it just worked earlier. Plus this PR is not touching anything related to it.

mik-dass

/lgtm

openshift-bot · 2020-01-07T11:08:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

dharmit · 2020-01-07T11:10:07Z

level=fatal msg="failed to fetch Cluster: failed to generate asset \"Cluster\": failed to create cluster: failed to apply using Terraform"

/test v4.1-integration-e2e-benchmark

dharmit · 2020-01-07T12:47:19Z

/hold do-not-merge

Adding integration test for this. I was under an impression that we don't have service catalog tests in the CI.

dharmit · 2020-01-08T13:07:38Z

/retest

dharmit · 2020-01-10T08:28:47Z

Travis is failing due to:

Created dir: /tmp/863945455
Creating a new project: ltwieroyye
Running odo with args [odo project create ltwieroyye -w -v4]
[odo]  •  Waiting for project to come up  ...
[odo] I0109 14:34:54.285469   31887 occlient.go:537] Project ltwieroyye now exists
[odo]  ✓  Waiting for project to come up [844ms]
[odo]  ✓  Project 'ltwieroyye' is ready for use
[odo]  ✓  New project created and now using project: ltwieroyye
[odo] I0109 14:34:54.293428   31887 odo.go:77] Could not get the latest release information in time. Never mind, exiting gracefully :)
Created dir: /tmp/526972802
Created dir: /tmp/454825721
Current working dir: /home/travis/gopath/src/github.com/openshift/odo/tests/integration/servicecatalog
Running odo with args [odo service create --app oahjjh -w dh-postgresql-apb --project ltwieroyye --plan dev -p postgresql_user=luke -p postgresql_password=secret -p postgresql_database=my_data -p postgresql_version=9.6]
[odo] Deploying service dh-postgresql-apb of type: dh-postgresql-apb
[odo]  •  Deploying service  ...
[odo]  ✓  Deploying service [34ms]
[odo]  •  Waiting for service to come up  ...
[odo]  ✓  Waiting for service to come up [1m]
[odo]  ✓  Service 'dh-postgresql-apb' is ready for use
[odo] Optionally, link dh-postgresql-apb to your component by running: 'odo link <component-name>'
Running oc with args [oc get serviceinstance -o name -n ltwieroyye]
[oc] serviceinstance.servicecatalog.k8s.io/dh-postgresql-apb
Running odo with args [odo app delete oahjjh -f]
[odo]  ✗  oahjjh app does not exists
Setting current dir to: /home/travis/gopath/src/github.com/openshift/odo/tests/integration/servicecatalog
Deleting project: ltwieroyye
Running odo with args [odo project delete ltwieroyye -f]
[odo] This project contains the following applications, which will be deleted
[odo] Application oahjjh
[odo] This application has following service that will be deleted
[odo] service named dh-postgresql-apb of type dh-postgresql-apb
[odo]  •  Deleting project ltwieroyye  ...
[odo]  ✓  Deleting project ltwieroyye [6s]
[odo]  ✓  Deleted project : ltwieroyye
Deleting dir: /tmp/863945455
Deleting dir: /tmp/526972802
Deleting dir: /tmp/454825721
• Failure [71.751 seconds]
odo service command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:16
  When the application is deleted
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:421
    should delete the service(s) in the application as well [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:429
    No future change is possible.  Bailing out early after 0.505s.
    Running odo with args [odo app delete oahjjh -f]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_run.go:33

which indicates that the app we're trying to delete doesn't exist on the cluster. However, on my local minishift setup, it fails with:

NAME                  TYPE                  PLAN     STATUS      
dh-postgresql-apb     dh-postgresql-apb     dev      Deprovisioning               
Running odo with args [odo service list --app ogrssx]                                                                  
[odo] NAME                  TYPE                  PLAN     STATUS  
[odo] dh-postgresql-apb     dh-postgresql-apb     dev      Deprovisioning                                              
NAME                  TYPE                  PLAN     STATUS                                                                                                                                                                                   
dh-postgresql-apb     dh-postgresql-apb     dev      Deprovisioning      
Running odo with args [odo service list --app ogrssx]                                                                  
[odo]  ✗  There are no services deployed for this application                                         
Setting current dir to: /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog                                                                                                                                          
Deleting project: yxavlqckrg                                                                                           
Running odo with args [odo project delete yxavlqckrg -f]                                                               
[odo]  •  Deleting project yxavlqckrg  ...                                                                             
[odo]  ✓  Deleting project yxavlqckrg [6s]                                                                             
[odo]  ✓  Deleted project : yxavlqckrg               
Deleting dir: /tmp/190614664                                                                                           
Deleting dir: /tmp/516509255                                                                                           
Deleting dir: /tmp/798073594                                                                                           
                                                                                                                       
• Failure [116.506 seconds]                          
odo service command tests                                                                                              
/home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:16      
  When the application is deleted                                                                                      
  /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:421
    should delete the service(s) in the application as well [It]                                                       
    /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:429
                                                                                                                       
    No future change is possible.  Bailing out early after 0.344s.
    Running odo with args [odo service list --app ogrssx]                                                              
    Expected                                         
        <int>: 1                                                                                                       
    to match exit code:                                                                                                
        <int>: 0                                                                                                       
                                                                                                                       
    /home/dshah/go/src/github.com/openshift/odo/tests/helper/helper_run.go:33                                          
------------------------------                                                                                         
                                                                                                                       
                                                                                                                       
Summarizing 1 Failure:                                                                                                 
                                                                                                                       
[Fail] odo service command tests When the application is deleted [It] should delete the service(s) in the application as well                                                                                                                 
/home/dshah/go/src/github.com/openshift/odo/tests/helper/helper_run.go:33
                                                                                                                       
Ran 1 of 22 Specs in 116.506 seconds                                                                                   
FAIL! -- 0 Passed | 1 Failed | 0 Pending | 21 Skipped
--- FAIL: TestServicecatalog (116.51s)                                                                                 
FAIL

In the tests I've called helper.WaitForCmdOut such that failure of the command doesn't cause the test spec to fail. Yet, it's failing.

@amitkrout can you help me understand what's going wrong here? 😞

dharmit · 2020-01-10T09:41:18Z

In the tests I've called helper.WaitForCmdOut such that failure of the command doesn't cause the test spec to fail. Yet, it's failing.

@amitkrout can you help me understand what's going wrong here?

Never mind. I was wrong in expecting things to work if the underlying command fails. WaitForCmdOut wraps CmdShouldPass so I figured a different approach. Added some sleep before checking the output of odo service list.

Hopefully the tests will pass this time. 😄

dharmit · 2020-03-19T07:41:23Z

@kadel @amitkrout the travis check is failing with same error as it fails for me in my local setup and I don't understand why that's the case or what I'm doing wrong. https://travis-ci.com/github/openshift/odo/jobs/298915517#L733-L909

girishramnani · 2020-03-19T08:23:32Z

tests/integration/servicecatalog/cmd_service_test.go

+
+			ocArgs = []string{"get", "serviceinstances"}
+			helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
+				return strings.Contains(output, "No resources found.")


@dharmit can you please print the output content here? I think No resources found. might be printed on stderr stream which WaitForCmdout doesn't check

Sure, let me check.

confirmed

Running oc with args [oc get serviceinstances] [oc] No resources found. GIRISH output= # its empty here

confirming that No resources found. is showing in the err stream

dharmit · 2020-03-19T12:40:45Z

Travis failure:

• Failure [31.691 seconds]
odo component command tests
/home/travis/gopath/src/github.com/openshift/odo/tests/integration/cmd_cmp_test.go:13
  when component is in the current directory and --project flag is used
  /home/travis/gopath/src/github.com/openshift/odo/tests/integration/component.go:475
    creates a local python component, pushes it and then deletes it using --all flag [It]
    /home/travis/gopath/src/github.com/openshift/odo/tests/integration/component.go:510
    No future change is possible.  Bailing out early after 22.515s.
    Running odo with args [odo push --context /tmp/148843195]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0
    /home/travis/gopath/src/github.com/openshift/odo/tests/helper/helper_run.go:34

4.2 integration failure:

Ginkgo ran 1 suite in 1h16m49.696326188s
Test Suite Failed
2020/03/19 11:47:56 Container test in pod integration-e2e-benchmark failed, exit code 2, reason Error
[Fail] odo preference and config command tests when using --now with config command [It] should successfully set and unset variables 
/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

I'm guessing these are flake.

/test v4.2-integration-e2e-benchmark

dharmit · 2020-03-20T10:34:01Z

/hold cancel

ready for another review @mik-dass @adisky @cdrage @kanchwala-yusuf

amitkrout · 2020-03-20T10:42:58Z

tests/integration/servicecatalog/cmd_service_test.go

+
+			ocArgs = []string{"get", "serviceinstances"}
+			helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
+				return strings.Contains(output, "Deprovisioning")


Deprovisioning literally seems the process is still going on. Mab be Deprovisioned would be the best fit for this. But it seems we don't have control over the oc output. So @dharmit Can you please confirm does the substring Deprovisioning means all the services link to the application are deleted.

Deprovisioning indeed means that the process of deletion of service is still going on. Once the service is deleted, the output of oc get serviceinstances becomes something like No resources found... since there are no service instances in the project. It won't print Deprovisioned for deleted service.

I'm trying to see if doing ocArgs = []string{"get", "serviceinstances", "2>&1"} helps. So far, it doesn't seem to be working on my test setup.

Well, trying to redirect stderr to stdout is not working:

Running oc with args [oc get serviceinstances 2>&1] [oc] Error from server (NotFound): serviceinstances.servicecatalog.k8s.io "2>&1" not found ------------------------------ Failure [20.698 seconds] odo service command tests /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:15 When the application is deleted /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:439 should delete the service(s) in the application as well [It] /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:444 No future change is possible. Bailing out early after 0.111s. Running oc with args [oc get serviceinstances 2>&1] Expected <int>: 1 to match exit code: <int>: 0 /home/dshah/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

Doesn't work when I use odo command either:

[odo] ✗ unknown command "2>&1" for "odo service list" ------------------------------ • Failure [19.730 seconds] odo service command tests /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:15 When the application is deleted /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:439 should delete the service(s) in the application as well [It] /home/dshah/go/src/github.com/openshift/odo/tests/integration/servicecatalog/cmd_service_test.go:444 No future change is possible. Bailing out early after 0.040s. Running odo with args [odo service list --app kushnf 2>&1] Expected <int>: 1 to match exit code: <int>: 0 /home/dshah/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34

Looks like using shell way of redirecting stderr to stdout doesn't work well from Go code. 😞

girishramnani · 2020-03-20T11:55:18Z

one quick fix here would be to augment the WaitForCmdOut with an extra var-arg includeStderr

func WaitForCmdOut(program string, args []string, timeout int, errOnFail bool, check func(output string) bool, includeStderr ...bool) bool {
	pingTimeout := time.After(time.Duration(timeout) * time.Minute)
	// this is a test package so time.Tick() is acceptable
	// nolint
	tick := time.Tick(time.Second)
	for {
		select {
		case <-pingTimeout:
			Fail(fmt.Sprintf("Timeout out after %v minutes", timeout))

		case <-tick:
			session := CmdRunner(program, args...)
			Eventually(session).Should(gexec.Exit(0), runningCmd(session.Command))
			session.Wait()
			output := string(session.Out.Contents())

			if len(includeStderr) > 0 && includeStderr[0] {
				output += "\n" // just so we can separate stuff
				output += string(session.Err.Contents())
			}
			if check(strings.TrimSpace(string(output))) {
				return true
			}
		}
	}
}

so now the WaitForCmdOut would be like

helper.WaitForCmdOut("oc", ocArgs, 1, true, func(output string) bool {
	return strings.Contains(output, "No resources found.")
}, true) // <- observe the extra true here. and this doesn't break any of existing code because 
           //`includeStderr` is a var-args parameter.

I know this might not be the most documentation friendly approach but soon we need to redo the helpers ( all of them ) to something nice which covers all our cases and are clean to use. Until that day this looks ok.

If there are no components in the application but the only some service then `odo app delete <app-name>` won't show the list of services that will be deleted as a result of deleting the application. This commit fixes that behaviour.

cdrage

Tested, works, and code LGTM! :)

/lgtm

cdrage · 2020-03-24T17:03:30Z

pkg/application/application.go

+	svcList, err := service.List(client, name)
+	if err != nil {
+		// error is returned when there's no Service Catalog enabled in the service
+		glog.V(4).Infof("Service catalog is not enabled in the cluster, skipping service deletion")


nitpick, it's Service Catalog

cdrage · 2020-03-24T17:04:12Z

tests/integration/servicecatalog/cmd_service_test.go

+
+			helper.CmdShouldPass("odo", "app", "delete", app, "-f")
+
+			ocArgs = []string{"get", "serviceinstances"}


openshift-bot · 2020-03-24T17:35:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T17:48:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T18:01:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T18:27:10Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T18:40:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T18:54:52Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-24T19:06:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M labels Dec 31, 2019

openshift-ci-robot requested review from cdrage and girishramnani December 31, 2019 08:28

prietyc123 reviewed Dec 31, 2019

View reviewed changes

pkg/occlient/occlient.go Outdated Show resolved Hide resolved

dharmit commented Jan 2, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 3, 2020

prietyc123 reviewed Jan 3, 2020

View reviewed changes

mik-dass reviewed Jan 3, 2020

View reviewed changes

pkg/occlient/occlient.go Show resolved Hide resolved

dharmit mentioned this pull request Jan 3, 2020

Have checks for "bindingName" and "namespace" to avoid empty values in "CreateServiceBinding" #2493

Closed

mik-dass approved these changes Jan 7, 2020

View reviewed changes

openshift-ci-robot assigned mik-dass Jan 7, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 7, 2020

dharmit mentioned this pull request Jan 7, 2020

Add validation for empty values in pkg/occlient/occlient.go #598

Closed

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. and removed lgtm Indicates that a PR is ready to be merged. Required by Prow. labels Jan 7, 2020

girishramnani reviewed Mar 19, 2020

View reviewed changes

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Mar 20, 2020

amitkrout reviewed Mar 20, 2020

View reviewed changes

dharmit added 10 commits March 24, 2020 13:12

Fix typos in comments

721b53f

List services that will be deleted upon app deletion

701d066

If there are no components in the application but the only some service then `odo app delete <app-name>` won't show the list of services that will be deleted as a result of deleting the application. This commit fixes that behaviour.

Add labels to Service Binding

64e3d03

Delete the ServiceInstance(s) before deleting the application

0d84c2f

Add labels to unit tests for CreateServiceBinding

31ab1ae

Skipping service deletion when Service Catalog is not enabled

40bec68

Remove a code comment based on PR review

f200a47

Add integration tests for service deletion upon app deletion

3efe428

Remove sleep from tests and use oc command in helper

7f459f4

Make test helper function return stderr

f8b099e

cdrage approved these changes Mar 24, 2020

View reviewed changes

openshift-ci-robot assigned cdrage Mar 24, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 24, 2020

openshift-merge-robot merged commit 796991d into redhat-developer:master Mar 24, 2020

dharmit deleted the fix-2113 branch May 15, 2020 04:41

rm3l added the estimated-size/M (10-20) Rough sizing for Epics. About 1 sprint of work for one person label Jun 18, 2023


		helper.CmdShouldPass("odo", "app", "delete", app, "-f")

		ocArgs = []string{"get", "serviceinstances"}

Delete services belonging to an application during 'odo app delete' #2491

Delete services belonging to an application during 'odo app delete' #2491

Conversation

dharmit commented Dec 31, 2019

dharmit commented Jan 2, 2020

girishramnani commented Jan 2, 2020

Choose a reason for hiding this comment

dharmit commented Jan 2, 2020

girishramnani commented Jan 3, 2020

openshift-ci-robot commented Jan 3, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharmit commented Jan 3, 2020

girishramnani commented Jan 3, 2020

dharmit commented Jan 3, 2020

mik-dass left a comment

Choose a reason for hiding this comment

openshift-bot commented Jan 7, 2020

dharmit commented Jan 7, 2020

dharmit commented Jan 7, 2020

dharmit commented Jan 8, 2020

dharmit commented Jan 10, 2020

dharmit commented Jan 10, 2020

dharmit commented Mar 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dharmit commented Mar 19, 2020

dharmit commented Mar 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

girishramnani commented Mar 20, 2020

cdrage left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020

openshift-bot commented Mar 24, 2020