Verify deployment config after component create with flags #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
|
/retest |
prietyc123
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
amitkrout
suggested changes
Jan 9, 2020
tests/helper/helper_oc.go
Outdated
| @@ -181,6 +181,13 @@ func (oc *OcRunner) DescribeDc(dcName string, namespace string) string { | |||
| return strings.TrimSpace(describeInfo) | |||
| } | |||
|
|
|||
| // GetDcPorts returns the ports of the component | |||
| func (oc *OcRunner) GetDcPorts(componentName string, appName string, project string) string { | |||
| session := CmdShouldPass(oc.path, "get", "dc", componentName+"-"+appName, "--namespace", project, | |||
| @@ -202,7 +209,7 @@ func (oc *OcRunner) MaxCPU(componentName string, appName string, project string) | |||
| return maxMemory | |||
| } | |||
|
|
|||
| // MinCPU reuturns maximum cpu | |||
| // MinCPU reuturns minimum cpu | |||
There was a problem hiding this comment.
you resolved the maximum to minimum correctly but missed the reuturns 😆
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rm3l
added
the
estimated-size/S (5-10)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What does does this PR do / why we need it:
Verifies deployment config with flags.
Which issue(s) this PR fixes:
Fixes #2483
How to test changes / Special notes to the reviewer:
$ make test-cmd-cmp && make test-cmd-cmp-sub