Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved platfrom specific file separator in test #2524

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind test
/kind bug

What does does this PR do / why we need it:

Resolves platform specific file separator in test

Which issue(s) this PR fixes:

Fixes #2523

How to test changes / Special notes to the reviewer:

make test-cmd-push

Note : No such type of issues are found in other integration test files.

@openshift-ci-robot openshift-ci-robot added kind/test kind/bug Categorizes issue or PR as related to a bug. labels Jan 21, 2020
@prietyc123
Copy link
Contributor Author

2020/01/21 09:13:18 Resolved source https://github.com/openshift/odo to master@44699f53, merging: #2524 535a8fbf @prietyc123
2020/01/21 09:13:18 Using namespace ci-op-rttc4r7p
2020/01/21 09:13:18 Running root, [release-inputs], src, [images], [release:latest], integration-e2e-benchmark
2020/01/21 09:13:18 Creating namespace ci-op-rttc4r7p
2020/01/21 09:13:18 Creating rolebinding for user prietyc123 in namespace ci-op-rttc4r7p
2020/01/21 09:13:18 Ran for 0s
2020/01/21 09:13:19 Submitted failure event to sentry (id=37894066794545109a43cad1deca2908)
error: could not initialize namespace: could not create role binding for: rolebindings.rbac.authorization.k8s.io is forbidden: User "system:serviceaccount:ci:ci-operator" cannot create rolebindings.rbac.authorization.k8s.io in the namespace "ci-op-rttc4r7p": no RBAC policy matched

/retest

@prietyc123 prietyc123 self-assigned this Jan 21, 2020
Copy link
Contributor

@amitkrout amitkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 21, 2020
@amitkrout
Copy link
Contributor

ping @girishramnani

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jan 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 58d5343 into redhat-developer:master Jan 21, 2020
@rm3l rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of platform specific file separator in tests
6 participants