add app and project in the create service equivalent command template #2708

girishramnani · 2020-03-12T07:12:11Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring

What does does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #2696

How to test changes / Special notes to the reviewer:
Create a service and check the equivalent command

$ odo service create --app test 
? Which kind of service do you wish to create database
? Which database service class should we use  [Use arrows to move, type to filter]
  dh-mssql-apb
  dh-mysql-apb
  dh-postgresql-apb
> mariadb-persistent
? Which database service class should we use mariadb-persistent
? Enter a value for string property DATABASE_SERVICE_NAME (Database Service Name): mariadb
? Enter a value for string property MARIADB_VERSION (Version of MariaDB Image): 10.2
? Enter a value for string property MEMORY_LIMIT (Memory Limit): 512Mi
? Enter a value for string property MYSQL_DATABASE (MariaDB Database Name): sampledb
? Enter a value for string property VOLUME_CAPACITY (Volume Capacity): 1Gi
? Provide values for non-required properties No
? How should we name your service  mariadb-persistent
? Output the non-interactive version of the selected options Yes
? Wait for the service to be ready No
Deploying service mariadb-persistent of type: mariadb-persistent
 ✓  Deploying service [29ms]
 ✓  Service 'mariadb-persistent' was created

Progress of the provisioning will not be reported and might take a long time
You can see the current status by executing 'odo service list'
Optionally, link mariadb-persistent to your component by running: 'odo link <component-name>'
Equivalent command:
odo service create mariadb-persistent mariadb-persistent --app test --project testproject --plan default -p DATABASE_SERVICE_NAME=mariadb -p MARIADB_VERSION=10.2 -p MEMORY_LIMIT=512Mi -p MYSQL_DATABASE=sampledb -p VOLUME_CAPACITY=1Gi

It should have app and project flags

girishramnani · 2020-03-12T08:00:09Z

/retest

girishramnani · 2020-03-12T08:21:12Z

/retest

girishramnani · 2020-03-12T08:36:47Z

/retest

girishramnani · 2020-03-12T08:36:55Z

error: could not run steps: step integration-e2e-benchmark failed: could not create or restart template instance: unable to delete completed template instance: waited for pod integration-e2e-benchmark deletion for 600s, was not deleted

kadel · 2020-03-12T17:10:15Z

/retest
/approve

openshift-ci-robot · 2020-03-12T17:10:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2020-03-12T19:54:41Z

Codecov Report

Merging #2708 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2708   +/-   ##
=======================================
  Coverage   43.92%   43.92%           
=======================================
  Files          86       86           
  Lines        7757     7757           
=======================================
  Hits         3407     3407           
  Misses       4015     4015           
  Partials      335      335

Impacted Files	Coverage Δ
pkg/odo/cli/service/create.go	`20% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4852786...4f88092. Read the comment docs.

kanchwala-yusuf · 2020-03-17T07:50:34Z

/lgtm

openshift-bot · 2020-03-17T07:59:48Z

/retest