Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labeling for GitHub issues #2720

Merged

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 13, 2020

What type of PR is this?

/kind documentation

What does does this PR do / why we need it:

Updates the labeling for GitHub issue submission

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What type of PR is this?**

/kind documentation

**What does does this PR do / why we need it**:

Updates the labeling for GitHub issue submission

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #2720 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2720      +/-   ##
==========================================
- Coverage   43.83%   43.36%   -0.47%     
==========================================
  Files          86       86              
  Lines        7757     7907     +150     
==========================================
+ Hits         3400     3429      +29     
- Misses       4019     4137     +118     
- Partials      338      341       +3
Impacted Files Coverage Δ
...g/devfile/adapters/kubernetes/component/adapter.go 33.93% <0%> (-35.42%) ⬇️
pkg/devfile/adapters/helper.go 16.66% <0%> (-6.42%) ⬇️
pkg/component/watch.go 66% <0%> (-2%) ⬇️
pkg/util/util.go 65.73% <0%> (-1.03%) ⬇️
pkg/testingutil/devfile.go 0% <0%> (ø) ⬆️
pkg/component/component.go 24.3% <0%> (+0.27%) ⬆️
pkg/kclient/generators.go 91.25% <0%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02fbd3d...a06e234. Read the comment docs.

@kadel
Copy link
Member

kadel commented Mar 16, 2020

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 16, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 16, 2020
@openshift-merge-robot openshift-merge-robot merged commit e0a3351 into redhat-developer:master Mar 16, 2020
@cdrage cdrage deleted the update-issue-template branch January 14, 2022 14:57
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants