update supported image list and use the updated bootstrap image for CI

[girishramnani]

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake
/kind code-refactoring

What does does this PR do / why we need it:
init-image PR related to this redhat-developer/odo-init-image#50
update supported image list and use the updated bootstrap image for CI ( this needs to be reversed ) and also removed unsupported nodejs tests

Which issue(s) this PR fixes:

Fixes #2603
Fixes #2640
Fixes #2647
Fixes #2664
Fixes #2639 (as per @mik-dass confirmation in the comments )
Fixes #2663 ( as per @mik-dass confirmation in the comments )

How to test changes / Special notes to the reviewer:
Try smart push and debug scenarios on 4.4 cluster

[girishramnani]

/hold

[girishramnani]

need to change the bootstrap image to a production registry. currently using my own.

[mik-dass]

This seems to fix all the debug scenarios for me locally. Also #2639 seems to be fixed. Even all the push scenarios passed for me locally. But I don't see any nodejs components in the supported table.

[mrinaldas@localhost nodejs-ex]$ odo catalog list components 
Odo Supported OpenShift Components:
NAME     PROJECT       TAGS
java     openshift     11,8,latest

Odo Unsupported OpenShift Components:
NAME              PROJECT       TAGS
dotnet            openshift     2.1,3.0,3.1,latest
golang            openshift     1.11.5,latest
httpd             openshift     2.4,latest
modern-webapp     openshift     10.x,latest
nginx             openshift     1.10,1.14,latest
nodejs            openshift     10,12,latest
perl              openshift     5.26,latest
php               openshift     7.2,7.3,latest
python            openshift     2.7,3.6,latest
ruby              openshift     2.4,2.5,latest

I also get a warning while component creation for nodejs

[mrinaldas@localhost nodejs-ex]$ odo create nodejs --project ajskdjla
Warning: nodejs is not fully supported by odo, and it is not guaranteed to work
 ✓  Validating component [1s]

Please use `odo push` command to create the component with source deployed

Is this a expected behavior?

[girishramnani]

Interesting, Seems like I need to extract the image names and check what they are

[girishramnani]

@mik-dass resolved the catalog not showing nodejs as supported, also resolved failing tests

[codecov]

Codecov Report

Merging #2729 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
+ Coverage   43.45%   43.60%   +0.14%     
==========================================
  Files          94       94              
  Lines        8721     8726       +5     
==========================================
+ Hits         3790     3805      +15     
+ Misses       4563     4557       -6     
+ Partials      368      364       -4     

Impacted Files	Coverage Δ
pkg/catalog/catalog.go	52.43% <100.00%> (+0.84%)	⬆️
pkg/watch/watch.go	69.41% <0.00%> (+5.88%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb3fa51...2787dd9. Read the comment docs.

[amitkrout]

Will check it locally and update here

[mik-dass]

#2729 (comment) seems to be resolved with the new changes

[amitkrout]

@girishramnani 3.11 failure - https://travis-ci.com/github/openshift/odo/jobs/299762915#L774

same as

 Expected
        <string>: Warning: nodejs:latest is not fully supported by odo, and it is not guaranteed to work
         •  Validating component  ...
 ✓  Validating component [23ms]
        Please use `odo push` command to create the component with source deployed

[girishramnani]

/retest

[amitkrout]

@girishramnani

#2664 - #2664 (comment)
#2647 - #2647 (comment)

it works for both the issue fixes

[cdrage]

/kind feature

[prietyc123]

@girishramnani It seems #2640 is not fixed yet. As I can see odo component create nodejs is still throwing warning on 4.4 cluster.

$ odo component create nodejs --context ../tests/examples/source/nodejs
Warning: nodejs is not fully supported by odo, and it is not guaranteed to work
 ✓  Validating component [806ms]

Please use `odo push` command to create the component with source deployed
$ oc version
Client Version: 4.4.0-0.ci-2020-02-26-215902
Server Version: 4.4.0-0.ci-2020-03-18-044507
Kubernetes Version: v1.17.1

[prietyc123]

@girishramnani It seems #2640 is not fixed yet. As I can see odo component create nodejs is still throwing warning on 4.4 cluster.

$ odo component create nodejs --context ../tests/examples/source/nodejs
Warning: nodejs is not fully supported by odo, and it is not guaranteed to work
 ✓  Validating component [806ms]

Please use `odo push` command to create the component with source deployed
$ oc version
Client Version: 4.4.0-0.ci-2020-02-26-215902
Server Version: 4.4.0-0.ci-2020-03-18-044507
Kubernetes Version: v1.17.1

Sorry my bad.
Because of some left steps I got this error. #2640 is good to go 👍

[girishramnani]

/retest

[amitkrout]

@girishramnani #2640 - #2640 (comment)

please do not remove the hold label until 3.11 issue is not fixed.

[girishramnani]

/hold cancel
now this PR also uses master's init image

[girishramnani]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

/lgtm