Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List devfile component without connecting cluster if experimental flag is enabled #2749

Conversation

GeekArthur
Copy link
Contributor

Signed-off-by: jingfu wang jingfu.j.wang@ibm.com

What type of PR is this?
/kind bug

What does does this PR do / why we need it:
If the experimental flag is enabled, user should be able to list devfile components even if user doesn't connect to OpenShift cluster. Instead of failing the odo catalog list components, we output the following warning to user:

odo catalog list components                                                                                  ✔  17:00:33 
 ⚠  Please log in to an OpenShift cluster to list OpenShift/s2i components

Odo Supported Devfile Components:
NAME                 DESCRIPTION
java-spring-boot     Spring Boot® using IBM Java
openLiberty          Open Liberty microservice in Java

Which issue(s) this PR fixes:
Fixes #2740
Fixes #2706

How to test changes / Special notes to the reviewer:

Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 23, 2020
@GeekArthur
Copy link
Contributor Author

/assign

@GeekArthur
Copy link
Contributor Author

@kadel Please review this PR, thanks!

Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick comment and a question Jingfu

pkg/odo/cli/catalog/list/components.go Outdated Show resolved Hide resolved
pkg/odo/cli/catalog/list/components.go Outdated Show resolved Hide resolved
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur
Copy link
Contributor Author

GeekArthur commented Mar 25, 2020

@cdrage @johnmcollier Comments addressed, please review again, thanks!

@GeekArthur
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #2749 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2749      +/-   ##
=========================================
- Coverage   43.71%   43.5%   -0.21%     
=========================================
  Files          87      91       +4     
  Lines        8066    8222     +156     
=========================================
+ Hits         3526    3577      +51     
- Misses       4193    4297     +104     
- Partials      347     348       +1
Impacted Files Coverage Δ
pkg/kclient/deployments.go 34.66% <0%> (-54.99%) ⬇️
pkg/application/application.go 41.26% <0%> (-6.01%) ⬇️
...g/devfile/adapters/kubernetes/component/adapter.go 33.67% <0%> (-0.53%) ⬇️
pkg/lclient/images.go 60% <0%> (ø)
pkg/lclient/fakeclient.go 42.62% <0%> (ø)
pkg/lclient/client.go 0% <0%> (ø)
pkg/lclient/containers.go 88.88% <0%> (ø)
pkg/occlient/occlient.go 52.82% <0%> (+0.02%) ⬆️
pkg/component/watch.go 74% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a56a67...4e5140e. Read the comment docs.

@GeekArthur
Copy link
Contributor Author

/retest

1 similar comment
@GeekArthur
Copy link
Contributor Author

/retest

@kadel
Copy link
Member

kadel commented Mar 26, 2020

comments addressed, and this is a small change

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit a424b75 into redhat-developer:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
6 participants