-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List devfile component without connecting cluster if experimental flag is enabled #2749
List devfile component without connecting cluster if experimental flag is enabled #2749
Conversation
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
/assign |
@kadel Please review this PR, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick comment and a question Jingfu
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@cdrage @johnmcollier Comments addressed, please review again, thanks! |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
=========================================
- Coverage 43.71% 43.5% -0.21%
=========================================
Files 87 91 +4
Lines 8066 8222 +156
=========================================
+ Hits 3526 3577 +51
- Misses 4193 4297 +104
- Partials 347 348 +1
Continue to review full report at Codecov.
|
/retest |
1 similar comment
/retest |
comments addressed, and this is a small change /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jingfu wang jingfu.j.wang@ibm.com
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
If the experimental flag is enabled, user should be able to list devfile components even if user doesn't connect to OpenShift cluster. Instead of failing the
odo catalog list components
, we output the following warning to user:Which issue(s) this PR fixes:
Fixes #2740
Fixes #2706
How to test changes / Special notes to the reviewer: