Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to skip CI when pushing docs #2757

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 25, 2020

What type of PR is this?
/kind documentation
[skip ci]

What does does this PR do / why we need it:

This improves pushing documentation changes by including [skip ci]
somewhere in the commit message in order to skip any Travis CI build
from running.

Which issue(s) this PR fixes:

Fixes #2704

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage
Copy link
Member Author

cdrage commented Mar 25, 2020

Ayyy it worked, Travis isn't showing 👍

@amitkrout
Copy link
Contributor

Ayyy it worked, Travis isn't showing 👍

Yup, it works for travis CI. Also we need to make it work for OpenShift CI (prow). AFAIK there is one attribute, we just need to add in CI job to skip the build. I will check it again and share the reference.

@amitkrout
Copy link
Contributor

amitkrout commented Mar 28, 2020

@cdrage Created pr openshift/release#7987 to disable OpenShift CI only if docs/ are changed in odo repo.

@cdrage
Copy link
Member Author

cdrage commented Mar 30, 2020

openshift/release#7987 Has been merged :)

**What type of PR is this?**
/kind documentation
[skip ci]

**What does does this PR do / why we need it**:

This improves pushing documentation changes by including `[skip ci]`
somewhere in the commit message in order to skip any Travis CI build
from running.

**Which issue(s) this PR fixes**:

Fixes redhat-developer#2704

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 8, 2020
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 9, 2020
@dharmit
Copy link
Member

dharmit commented Apr 9, 2020

All integration checks failing with the message:

error: could not run steps: step integration-e2e-benchmark failed: failed to acquire lease: resources not found 

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 04c5e50 into redhat-developer:master Apr 9, 2020
@cdrage cdrage deleted the add-skip-ci branch January 14, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable CI run only for doc changes pr
7 participants