-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for --help / -h / help #2759
Add tests for --help / -h / help #2759
Conversation
**What type of PR is this?** /kind test **What does does this PR do / why we need it**: Adds some simple help integration tests **Which issue(s) this PR fixes**: Fixes redhat-developer#1045 **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com>
/test v4.3-integration-e2e-benchmark |
looks good to me 👍 /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for the pr
Codecov Report
@@ Coverage Diff @@
## master #2759 +/- ##
==========================================
- Coverage 43.71% 43.48% -0.24%
==========================================
Files 87 91 +4
Lines 8066 8222 +156
==========================================
+ Hits 3526 3575 +49
- Misses 4193 4298 +105
- Partials 347 349 +2
Continue to review full report at Codecov.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
What does does this PR do / why we need it:
Adds some simple help integration tests
Which issue(s) this PR fixes:
Fixes #1045
How to test changes / Special notes to the reviewer:
N/A
Signed-off-by: Charlie Drage charlie@charliedrage.com