Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for --help / -h / help #2759

Merged

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 25, 2020

What type of PR is this?
/kind test

What does does this PR do / why we need it:

Adds some simple help integration tests

Which issue(s) this PR fixes:

Fixes #1045

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

**What type of PR is this?**
/kind test

**What does does this PR do / why we need it**:

Adds some simple help integration tests

**Which issue(s) this PR fixes**:

Fixes redhat-developer#1045

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@amitkrout
Copy link
Contributor

 ✗  Applying configuration [124ms]
[odo]  ✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to update DeploymentConfig for nodejs component: unable to update the current DeploymentConfig nodejs-app: unable to update DeploymentConfig nodejs-app: Operation cannot be fulfilled on deploymentconfigs.apps.openshift.io "nodejs-app": the object has been modified; please apply your changes to the latest version and try again

/test v4.3-integration-e2e-benchmark

@prietyc123
Copy link
Contributor

looks good to me 👍

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
Copy link
Contributor

@amitkrout amitkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the pr

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2759 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   43.71%   43.48%   -0.24%     
==========================================
  Files          87       91       +4     
  Lines        8066     8222     +156     
==========================================
+ Hits         3526     3575      +49     
- Misses       4193     4298     +105     
- Partials      347      349       +2
Impacted Files Coverage Δ
pkg/kclient/deployments.go 34.66% <0%> (-54.99%) ⬇️
pkg/application/application.go 41.26% <0%> (-6.01%) ⬇️
...g/devfile/adapters/kubernetes/component/adapter.go 33.67% <0%> (-0.53%) ⬇️
pkg/lclient/images.go 60% <0%> (ø)
pkg/lclient/fakeclient.go 42.62% <0%> (ø)
pkg/lclient/client.go 0% <0%> (ø)
pkg/lclient/containers.go 88.88% <0%> (ø)
pkg/occlient/occlient.go 52.82% <0%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a56a67...355c078. Read the comment docs.

@kadel
Copy link
Member

kadel commented Mar 26, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit e87ee69 into redhat-developer:master Mar 27, 2020
@cdrage cdrage deleted the add-help-tests branch January 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for odo --help
6 participants