Error checking was removed for WaitAndGetPod #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind bug **What does does this PR do / why we need it**: Error checking was erronously removed when implementing event information. Instead of tests failing, they timed out instead.. See this line of code: https://github.com/openshift/odo/pull/2627/files#diff-6025e9b620e9321c03c11bf29e5c4dbdL1848 **Which issue(s) this PR fixes**: Fixes N/A, no issue was created. **How to test changes / Special notes to the reviewer**: N/A Signed-off-by: Charlie Drage <charlie@charliedrage.com>
openshift-ci-robot
added
the
kind/bug
|
/retest Need this merged in order to get testing working again locally (it just times out after 5 minutes). |
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
=========================================
- Coverage 43.48% 43.4% -0.08%
=========================================
Files 91 91
Lines 8222 8224 +2
=========================================
- Hits 3575 3570 -5
- Misses 4298 4306 +8
+ Partials 349 348 -1
Continue to review full report at Codecov.
|
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
Error checking was erronously removed when implementing event
information. Instead of tests failing, they timed out instead..
See this line of code:
https://github.com/openshift/odo/pull/2627/files#diff-6025e9b620e9321c03c11bf29e5c4dbdL1848
Which issue(s) this PR fixes:
Fixes N/A, no issue was created.
How to test changes / Special notes to the reviewer:
N/A
Signed-off-by: Charlie Drage charlie@charliedrage.com