Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed get service command flake #2764

Merged

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind flake

What does does this PR do / why we need it:

Fixes https://travis-ci.com/github/openshift/odo/jobs/302769701#L809

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:
Ideally Travis should not get such kind of flake.

@openshift-ci-robot openshift-ci-robot added the flake Categorizes issue or PR as related to a flaky test. label Mar 26, 2020
Copy link
Contributor

@amitkrout amitkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 26, 2020
@amitkrout
Copy link
Contributor

 [odo]  ✗  Applying configuration [319ms]
[odo]  ✗  Failed To Update Config To Component Deployed.
[odo] Error: unable to update DeploymentConfig for nodejs component: unable to update the current DeploymentConfig nodejs-app: unable to update DeploymentConfig nodejs-app: Operation cannot be fulfilled on deploymentconfigs.apps.openshift.io "nodejs-app": the object has been modified; please apply your changes to the latest version and try again 

/retest

@amitkrout
Copy link
Contributor

#2642
/retest

@kadel
Copy link
Member

kadel commented Mar 26, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #2764 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2764   +/-   ##
=======================================
  Coverage   43.48%   43.48%           
=======================================
  Files          91       91           
  Lines        8222     8222           
=======================================
  Hits         3575     3575           
  Misses       4298     4298           
  Partials      349      349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0add600...425fa1b. Read the comment docs.

@amitkrout
Copy link
Contributor

/refresh

@amitkrout
Copy link
Contributor

/retest

@amitkrout amitkrout merged commit 2bbffa0 into redhat-developer:master Mar 27, 2020
@openshift-ci-robot
Copy link
Collaborator

@prietyc123: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.2-integration-e2e-benchmark 425fa1b link /test v4.2-integration-e2e-benchmark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants