-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed get service command flake #2764
Fixed get service command flake #2764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
/lgtm
/retest |
#2642 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #2764 +/- ##
=======================================
Coverage 43.48% 43.48%
=======================================
Files 91 91
Lines 8222 8222
=======================================
Hits 3575 3575
Misses 4298 4298
Partials 349 349 Continue to review full report at Codecov.
|
/refresh |
/retest |
@prietyc123: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind flake
What does does this PR do / why we need it:
Fixes https://travis-ci.com/github/openshift/odo/jobs/302769701#L809
Which issue(s) this PR fixes:
Fixes NA
How to test changes / Special notes to the reviewer:
Ideally Travis should not get such kind of flake.