Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assemble and organise devfile integration tests Files #2771

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Assemble and organise devfile integration tests Files #2771

merged 3 commits into from
Apr 3, 2020

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind design

What does does this PR do / why we need it:

Assemble all the devfile integration tests Files into tests/integration/devfile

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:

Run make test-integration-devfile

@amitkrout
Copy link
Contributor

Thanks @prietyc123 for the pr.

@johnmcollier @GeekArthur @yangcao77 @kanchwala-yusuf Lets add devfile specific test in a separate package as later it will be easy to understand and maintain specific test if the volume of devfile test contribution increases.

Thanks for understanding

@amitkrout
Copy link
Contributor

/test unit

amitkrout
amitkrout reviewed Mar 30, 2020
View reviewed changes
tests/integration/devfile/cmd_devfile_catalog_test.go
@@ -1,4 +1,4 @@
package integration
package devfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Mar 30, 2020
@prietyc123
Copy link
Contributor Author

/retest

@amitkrout
Copy link
Contributor

/test v4.2-integration-e2e-benchmark

@GeekArthur
Copy link
Contributor

We may need someone adds approved label to trigger openshift bot for helping us retest the PR automatically.

@prietyc123
Copy link
Contributor Author

/retest

@amitkrout
Copy link
Contributor

/test v4.3-integration-e2e-benchmark

@amitkrout
Copy link
Contributor

amitkrout commented Apr 2, 2020 •
edited

We may need someone adds approved label to trigger openshift bot for helping us retest the PR automatically.

As @GeekArthur mentioned, @girishramnani Can you pease add the approve label here so that the pr will run continuously until it passes before auto merge. You can feel free to apply the approve label as only files has been moved to separate package without any code changes.

@amitkrout
Copy link
Contributor

prow failure
/test v4.3-integration-e2e-benchmark

3 similar comments
@amitkrout
Copy link
Contributor

prow failure
/test v4.3-integration-e2e-benchmark

@amitkrout
Copy link
Contributor

prow failure
/test v4.3-integration-e2e-benchmark

@amitkrout
Copy link
Contributor

prow failure
/test v4.3-integration-e2e-benchmark

@GeekArthur GeekArthur mentioned this pull request Apr 2, 2020
Merged
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Apr 2, 2020 •
edited

Codecov Report

Merging #2771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2771   +/-   ##
=======================================
  Coverage   43.59%   43.59%           
=======================================
  Files          91       91           
  Lines        8301     8301           
=======================================
  Hits         3619     3619           
  Misses       4333     4333           
  Partials      349      349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eb878e...3311ed2. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 385c4a7 into redhat-developer:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitkrout amitkrout amitkrout left review comments

@kanchwala-yusuf kanchwala-yusuf Awaiting requested review from kanchwala-yusuf

@mohammedzee1000 mohammedzee1000 Awaiting requested review from mohammedzee1000

Assignees

@amitkrout amitkrout

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@prietyc123 @amitkrout @GeekArthur @girishramnani @openshift-ci-robot @openshift-bot @openshift-merge-robot