Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test build on Windows #2783

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Fix unit test build on Windows #2783

merged 1 commit into from
Apr 7, 2020

Conversation

kadel
Copy link
Member

@kadel kadel commented Mar 31, 2020 •
edited

in glide.yaml replace github.com/kr/pty with github.com/creack/pty

What type of PR is this?

/kind bug

What does does this PR do / why we need it:

Successful UT build on windows

Which issue(s) this PR fixes:

Fixes #2630

How to test changes / Special notes to the reviewer:
Run make test on windows, It should run successfully.

Credit goes to @prietyc123, she was the one who figured out that we need to use github.com/creack/pty instead of github.com/kr/pty

This PR replaces #2766

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 31, 2020
@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited

Codecov Report

Merging #2783 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2783   +/-   ##
=======================================
  Coverage   43.47%   43.47%           
=======================================
  Files          91       91           
  Lines        8301     8301           
=======================================
  Hits         3609     3609           
  Misses       4339     4339           
  Partials      353      353
Impacted Files Coverage Δ
pkg/testingutil/survey_ui.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddefa1...7f0d614. Read the comment docs.

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 31, 2020
@kadel kadel changed the title [WIP] glide.yaml replace github.com/kr/pty with github.com/creack/pty Fix unit test build on Windows Mar 31, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Mar 31, 2020
@prietyc123 prietyc123 mentioned this pull request Mar 31, 2020
Closed
girishramnani
girishramnani reviewed Mar 31, 2020
View reviewed changes
glide.yaml
@@ -27,6 +27,9 @@ import:
- package: k8s.io/api
version: origin-4.1-kubernetes-1.13.4
repo: https://github.com/openshift/kubernetes-api.git
- package: github.com/kr/pty
version: v1.1.9
repo: https://github.com/creack/pty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaky ✌️

@amitkrout
Copy link
Contributor

/retest

1 similar comment
@kadel
Copy link
Member Author

kadel commented Apr 1, 2020

/retest

@prietyc123
Copy link
Contributor

/test v4.2-integration-e2e-benchmark

@prietyc123
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 2, 2020
@kadel
Copy link
Member Author

kadel commented Apr 2, 2020 •
edited

ping @girishramnani @cdrage this needs your /approve

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 7, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@kadel
Copy link
Member Author

kadel commented Apr 7, 2020

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 0e9e176 into redhat-developer:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girishramnani girishramnani girishramnani left review comments

@dharmit dharmit Awaiting requested review from dharmit

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@prietyc123 prietyc123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

making package testingutil and ui work for unit test build on windows
7 participants
@kadel @amitkrout @prietyc123 @girishramnani @openshift-ci-robot @openshift-bot @openshift-merge-robot