Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the messaging to avoid confusion #2802

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Change the messaging to avoid confusion #2802

merged 1 commit into from
Apr 3, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Apr 2, 2020

What type of PR is this?
/kind code-refactoring

What does does this PR do / why we need it:
Operators listed by odo catalog list services could or could not be
installed from Operator Hub.

Which issue(s) this PR fixes:

Fixes #2794

How to test changes / Special notes to the reviewer:
Enable the experimental mode and check output of odo catalog list services. Make sure at least one operator is installed in the cluster.

Operators listed by `odo catalog list services` could or could not be
installed from Operator Hub.
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 2, 2020
@kadel
Copy link
Member

kadel commented Apr 2, 2020

/approve
/retest

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2802 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2802   +/-   ##
=======================================
  Coverage   43.39%   43.39%           
=======================================
  Files          91       91           
  Lines        8312     8312           
=======================================
  Hits         3607     3607           
  Misses       4352     4352           
  Partials      353      353
Impacted Files Coverage Δ
pkg/odo/cli/catalog/util/util.go 40.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791be7f...2df8b1b. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 3587b9e into redhat-developer:master Apr 3, 2020
@dharmit dharmit deleted the fix-2794 branch April 3, 2020 05:01
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change messaging when listing operators installed in the cluster
8 participants