Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version and base image on Openshift CI #2830

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

> /kind api-change
> /kind bug
> /kind cleanup
> /kind deprecation
> /kind design
> /kind documentation
> /kind failing-test
> /kind feature
> /kind flake
> /kind code-refactoring

What does does this PR do / why we need it:

Updates the base image of go on openshift CI

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:
It should pull go-1.13+ image on Openshift CI

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 7, 2020
@prietyc123
Copy link
Contributor Author

prietyc123 commented Apr 7, 2020

Team I have updated the go version to 1.13 in Openshift CI to be in sync with our travis build env. So in case you are using any version less than this I would suggest let's migrate to 1.13 to be in sync actual dev env with CI setup.

@amitkrout
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2830 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
+ Coverage   43.53%   43.64%   +0.11%     
==========================================
  Files          94       94              
  Lines        8743     8743              
==========================================
+ Hits         3806     3816      +10     
+ Misses       4569     4563       -6     
+ Partials      368      364       -4     
Impacted Files Coverage Δ
pkg/watch/watch.go 69.41% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484a32d...5f6f8e7. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit c5d8e75 into redhat-developer:master Apr 7, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants