Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation on glide #2837

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Update documentation on glide #2837

merged 1 commit into from
Apr 8, 2020

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Apr 7, 2020

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind documentation

What does does this PR do / why we need it:

We're missing documentation on our make vendor-update command. So here
it is!

Which issue(s) this PR fixes:

N/A

How to test changes / Special notes to the reviewer:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage
Update documentation on glide
1330531 
**What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind documentation

**What does does this PR do / why we need it**:

We're missing documentation on our `make vendor-update` command. So here
it is!

**Which issue(s) this PR fixes**:

N/A

**How to test changes / Special notes to the reviewer**:

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
johnmcollier
johnmcollier approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@johnmcollier johnmcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm These were the instructions I followed when adding the docker client to odo and it worked well for me.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 7, 2020
@cdrage
Copy link
Member Author

cdrage commented Apr 7, 2020

/retest

@girishramnani
Copy link
Contributor

/approve

@girishramnani
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 8, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Apr 8, 2020 •
edited

Codecov Report

Merging #2837 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2837      +/-   ##
==========================================
- Coverage   43.60%   43.53%   -0.08%     
==========================================
  Files          94       94              
  Lines        8726     8743      +17     
==========================================
+ Hits         3805     3806       +1     
- Misses       4557     4569      +12     
- Partials      364      368       +4
Impacted Files Coverage Δ
pkg/watch/watch.go 63.52% <0.00%> (-5.89%) ⬇️
...g/devfile/adapters/kubernetes/component/adapter.go 26.94% <0.00%> (+1.43%) ⬆️
pkg/kclient/pods.go 43.83% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5931049...1330531. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 00262d8 into redhat-developer:master Apr 8, 2020
@cdrage cdrage deleted the update-doc-on-glide branch January 14, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmcollier johnmcollier johnmcollier approved these changes

@dharmit dharmit Awaiting requested review from dharmit

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

Assignees

@johnmcollier johnmcollier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cdrage @girishramnani @openshift-ci-robot @openshift-bot @johnmcollier @openshift-merge-robot