New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add owner reference to ingress and tlssecert metadata #2841
add owner reference to ingress and tlssecert metadata #2841
Conversation
Hi @yangcao77. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected when I do odo delete
. Code looks good as well.
/lgtm
Seeing following message on both 4.2 & 4.3 CI failures (4.2 link & 4.3 link):
Looks like it's hitting #2642 /test v4.2-integration-e2e-benchmark |
Details - https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2841/pull-ci-openshift-odo-master-v4.3-integration-e2e-benchmark/1820#1:build-log.txt%3A484 |
Codecov Report
@@ Coverage Diff @@
## master #2841 +/- ##
==========================================
- Coverage 43.23% 43.09% -0.14%
==========================================
Files 97 97
Lines 8878 8888 +10
==========================================
- Hits 3838 3830 -8
- Misses 4673 4690 +17
- Partials 367 368 +1
Continue to review full report at Codecov.
|
@yangcao77 Please enable and add the ingress check in this test scenario https://github.com/openshift/odo/blob/749739a9962a925df6bc876a5330b714400db704/tests/integration/devfile/cmd_devfile_delete_test.go#L60 /hold |
…eferenceToIngress
Signed-off-by: Stephanie <stephanie.cao@ibm.com>
/retest |
/test v4.2-integration-e2e-benchmark |
/unhold |
@mik-dass The delete test has been updated. Can you help add the approve and lgtm label? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me locally and CI is green.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yangcao77 I have added the lgtm label. I don't have the approval rights though. |
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
add owner reference to ingress and tlssecert metadata
Which issue(s) this PR fixes:
Fixes #2808
How to test changes / Special notes to the reviewer:
odo create nodejs
odo url create testurl1 --host 1.2.3.4.com --secure
odo push
=> Verify that creates a deployment
nodejs
, a ingresstesturl1
, and a tlssecretnodejs-tlssecret
kubectl delete deploy nodejs
=> verify the ingress and the tlssecret have been deleted along with the deployment