Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation links from 4.2 to 4.3 #2844

Merged
merged 2 commits into from Apr 9, 2020
Merged

Update documentation links from 4.2 to 4.3 #2844

merged 2 commits into from Apr 9, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Apr 8, 2020

What type of PR is this?
/kind documentation

What does does this PR do / why we need it:
We need it to keep the docs updated.

Which issue(s) this PR fixes:
NA

@dharmit
Copy link
Member Author

dharmit commented Apr 8, 2020

@Preeticp @boczkowska @cdrage I've used latest in the URL so that it always takes the users to latest version of OpenShift documentation. Let me know if this is not a good idea.

@Preeticp
Copy link
Contributor

Preeticp commented Apr 8, 2020

That's the way we want to do it @dharmit. Thank you!
LGTM

Just an observation and not a part of this PR: I think the odo architecture doc (https://docs.openshift.com/container-platform/latest/cli_reference/openshift_developer_cli/odo-architecture.html) is an important doc to link to from the Readme. WDYT?

@dharmit
Copy link
Member Author

dharmit commented Apr 8, 2020

Thanks, @Preeticp. And I agree with making architecture doc a part of the README. Since this PR is really small, I pushed a commit to add it just after the link to installing odo. If you think it'd make sense to have it a different place, please let me know.

@Preeticp
Copy link
Contributor

Preeticp commented Apr 8, 2020

LGTM, thank you!

@amitkrout
Copy link
Contributor

prow issue
/retest

@amitkrout
Copy link
Contributor

LGTM, thank you!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 9, 2020
@cdrage
Copy link
Member

cdrage commented Apr 9, 2020

/approve

@cdrage
Copy link
Member

cdrage commented Apr 9, 2020

/retest

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2844 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2844   +/-   ##
=======================================
  Coverage   43.67%   43.67%           
=======================================
  Files          95       95           
  Lines        8762     8762           
=======================================
  Hits         3827     3827           
  Misses       4571     4571           
  Partials      364      364           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cef105b...2c92db5. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5ab3fd9 into redhat-developer:master Apr 9, 2020
@dharmit dharmit deleted the readme-42-to-43 branch May 15, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants