New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to OpenShift cluster #2861
Remove references to OpenShift cluster #2861
Conversation
Signed-off-by: John Collier <John.J.Collier@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
/lgtm
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2861 +/- ##
==========================================
- Coverage 43.70% 43.68% -0.03%
==========================================
Files 97 97
Lines 8783 8801 +18
==========================================
+ Hits 3839 3845 +6
- Misses 4580 4593 +13
+ Partials 364 363 -1
Continue to review full report at Codecov.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Signed-off-by: John Collier John.J.Collier@ibm.com
What type of PR is this?
/kind cleanup
What does does this PR do / why we need it:
This PR changes references to
OpenShift cluster
tocluster
in places where the code could be referring to either an OpenShift cluster or Kubernetes cluster.Which issue(s) this PR fixes:
Fixes #2852
How to test changes / Special notes to the reviewer:
cluster
instead ofOpenShift cluster