Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to OpenShift cluster #2861

Merged

Conversation

johnmcollier
Copy link
Member

Signed-off-by: John Collier John.J.Collier@ibm.com

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind cleanup

What does does this PR do / why we need it:
This PR changes references to OpenShift cluster to cluster in places where the code could be referring to either an OpenShift cluster or Kubernetes cluster.

Which issue(s) this PR fixes:

Fixes #2852

How to test changes / Special notes to the reviewer:

  1. Build my branch
  2. Create / Delete a URL, verify that it says cluster instead of OpenShift cluster

Signed-off-by: John Collier <John.J.Collier@ibm.com>
Copy link
Contributor

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 9, 2020
@johnmcollier
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2861 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2861      +/-   ##
==========================================
- Coverage   43.70%   43.68%   -0.03%     
==========================================
  Files          97       97              
  Lines        8783     8801      +18     
==========================================
+ Hits         3839     3845       +6     
- Misses       4580     4593      +13     
+ Partials      364      363       -1     
Impacted Files Coverage Δ
pkg/util/util.go 65.40% <0.00%> (-1.70%) ⬇️
pkg/application/application.go 40.00% <0.00%> (-1.27%) ⬇️
pkg/odo/util/cmdutils.go 1.69% <0.00%> (ø)
pkg/occlient/occlient.go 52.73% <0.00%> (+0.03%) ⬆️
pkg/component/component.go 24.38% <0.00%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fffec54...d371dfa. Read the comment docs.

@kadel
Copy link
Member

kadel commented Apr 14, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 14, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 77681be into redhat-developer:master Apr 15, 2020
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo url create/delete output always references OpenShift clusters
7 participants