Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation so that it would proper render #2872

Merged
merged 1 commit into from Apr 14, 2020
Merged

Fix documentation so that it would proper render #2872

merged 1 commit into from Apr 14, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Apr 13, 2020

What type of PR is this?
/kind documentation
[skip ci]

What does does this PR do / why we need it:
We need it so that bullet points and sections of document would properly render.

Which issue(s) this PR fixes:
NA

How to test changes / Special notes to the reviewer:
Compare the rendered document against current master and proposed PR. This can be done by clicking "Display the rich diff" when reviewing the PR.

Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 14, 2020
@prietyc123
Copy link
Contributor

prietyc123 commented Apr 14, 2020

flake tracked on issue : #2878

Restarted the failed job.

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Apr 14, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #2872 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
- Coverage   43.26%   43.19%   -0.07%     
==========================================
  Files          97       97              
  Lines        8878     8878              
==========================================
- Hits         3841     3835       -6     
- Misses       4673     4675       +2     
- Partials      364      368       +4     
Impacted Files Coverage Δ
pkg/watch/watch.go 63.52% <0.00%> (-3.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 749739a...24ff47c. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0e0176e into redhat-developer:master Apr 14, 2020
@dharmit dharmit deleted the fix-asciidoc-formatting branch May 15, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants