Fixes watch test #2895
Fixes watch test #2895
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
removed
the
needs-rebase
mik-dass
force-pushed
the
watch_fix_mac
branch
4 times, most recently
from
7aacb57
to
ebceb54
Compare
openshift-ci-robot
added
kind/bug
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
mik-dass
requested review from
kadel,
prietyc123 and
amitkrout
and removed request for
mohammedzee1000 and
maysunfaisal
|
Can you please share how was this solved and what was the issue? |
|
prow issue |
The test setup uses ioutil for creating temp directories and folders. Thus all the files and folders have a random string attached to the end of their path. We use a glob expression Also we need to convert the glob expressions to their absolute forms for the watch function to work properly. |
|
prow issue |
There was a problem hiding this comment.
Tested 100 time om macOS and all the execution went fine.
$ for i in $(seq 1 100); do echo $i && go test /Users/amit/go/src/github.com/openshift/odo/pkg/watch/watch.go /Users/amit/go/src/github.com/openshift/odo/pkg/watch/watch_test.go -p 1 -count=1; done
1
ok command-line-arguments 21.104s
2
ok command-line-arguments 23.094s
3
ok command-line-arguments 21.103s
4
ok command-line-arguments 22.104s
5
ok command-line-arguments 22.104s
6
ok command-line-arguments 21.121s
7
ok command-line-arguments 25.100s
8
ok command-line-arguments 23.124s
9
ok command-line-arguments 27.118s
10
ok command-line-arguments 24.108s
[...]
90
ok command-line-arguments 24.117s
91
ok command-line-arguments 23.112s
92
ok command-line-arguments 22.100s
93
ok command-line-arguments 24.101s
94
ok command-line-arguments 22.097s
95
ok command-line-arguments 24.095s
96
ok command-line-arguments 21.109s
97
ok command-line-arguments 20.105s
98
ok command-line-arguments 22.105s
99
ok command-line-arguments 23.102s
100
ok command-line-arguments 27.107s
In the morning me and @mik-dass was working on the issue. So i understand the changes he has made.
/lgtm
openshift-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
I have also tested 100 time on macOS and all the execution passed. 👍 |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #2895 +/- ##
==========================================
+ Coverage 43.70% 43.73% +0.03%
==========================================
Files 102 102
Lines 9160 9160
==========================================
+ Hits 4003 4006 +3
+ Misses 4780 4778 -2
+ Partials 377 376 -1
Continue to review full report at Codecov.
|
|
/refresh |
|
@mik-dass: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind bug
/kind cleanup
/kind flake
What does does this PR do / why we need it:
This fixes the watch test for mac. Also refactors the devfile watch test.
Which issue(s) this PR fixes:
Fixes #2570
How to test changes / Special notes to the reviewer:
make testshould pass on mac (run at least 50-100 times)