Add push target into sample #2896

jichenjc · 2020-04-16T04:22:49Z

What type of PR is this?

/kind bug

What does does this PR do / why we need it:
the PushTarget is able to show in preference view but not in set/unset example

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

openshift-ci-robot · 2020-04-16T04:23:19Z

Hi @jichenjc. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2020-04-16T04:35:54Z

Codecov Report

Merging #2896 into master will increase coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
+ Coverage   42.95%   43.81%   +0.85%     
==========================================
  Files          97      102       +5     
  Lines        8917     9160     +243     
==========================================
+ Hits         3830     4013     +183     
- Misses       4719     4774      +55     
- Partials      368      373       +5

Impacted Files	Coverage Δ
pkg/lclient/containers.go	`58.97% <0.00%> (-29.92%)`	⬇️
pkg/devfile/adapters/helper.go	`10.71% <0.00%> (-5.96%)`	⬇️
pkg/odo/cli/service/create.go	`13.26% <0.00%> (-0.95%)`	⬇️
pkg/lclient/client.go	`0.00% <0.00%> (ø)`
pkg/lclient/images.go	`60.00% <0.00%> (ø)`
pkg/devfile/adapters/docker/component/utils.go	`65.51% <0.00%> (ø)`
pkg/devfile/adapters/docker/component/adapter.go	`70.58% <0.00%> (ø)`
pkg/lclient/storage.go	`100.00% <0.00%> (ø)`
pkg/devfile/adapters/docker/utils/utils.go	`100.00% <0.00%> (ø)`
pkg/lclient/generators.go	`100.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77681be...55c3a4d. Read the comment docs.

kadel · 2020-04-16T11:34:12Z

/ok-to-test

kadel · 2020-04-16T11:59:55Z

small straight forward fix

/lgtm
/approve
/retest

openshift-ci-robot · 2020-04-16T12:01:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kadel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-16T12:50:23Z

/retest