Push support: Event notification support for build and application status for IDE integration for devfile scenarios

[jgwest]

What type of PR is this?
/kind feature

What does does this PR do / why we need it:

Short answer: This PR enables JSON events to be emitted, on dev file push, when the -o json parameter is passed.

Long answer: Design proposal is here.

Parent issue:
#2550

How to test changes / Special notes to the reviewer:

# Set docker target OR ensure a valid Kube context is set
export ODO_EXPERIMENTAL=true

git clone https://github.com/odo-devfiles/nodejs-ex.git
cd nodejs-ex
odo create nodejs
odo push -f -o json

Sample output:

{"devFileCommandExecutionBegin":{"commandId":"devbuild","componentName":"runtime","commandLine":"npm install","groupKind":"build","timestamp":"1591336117.632920"}}
{"logText":{"text":"npm WARN nodejs-sample@1.0.0 No repository field.","stream":"stderr","timestamp":"1591336119.140467"}}
{"logText":{"text":"","stream":"stderr","timestamp":"1591336119.147436"}}
{"logText":{"text":"audited 50 packages in 0.892s","stream":"stdout","timestamp":"1591336119.435678"}}
{"logText":{"text":"found 0 vulnerabilities","stream":"stdout","timestamp":"1591336119.484515"}}
{"logText":{"text":"","stream":"stdout","timestamp":"1591336119.491524"}}
{"devFileCommandExecutionComplete":{"commandId":"devbuild","componentName":"runtime","commandLine":"npm install","groupKind":"build","timestamp":"1591336119.497485"}}
{"devFileCommandExecutionBegin":{"commandId":"devrun","componentName":"runtime","commandLine":"nodemon app.js","groupKind":"run","timestamp":"1591336119.505459"}}
{"logText":{"text":"devrun                                     OK","stream":"stdout","timestamp":"1591336120.799012"}}
{"logText":{"text":"debugrun                                   OK","stream":"stdout","timestamp":"1591336120.804983"}}
{"devFileCommandExecutionComplete":{"commandId":"devrun","componentName":"runtime","commandLine":"nodemon app.js","groupKind":"run","timestamp":"1591336120.810968"}}
{"devFileCommandExecutionBegin":{"commandId":"devrun","componentName":"runtime","commandLine":"nodemon app.js","groupKind":"run","timestamp":"1591336120.816952"}}
{"logText":{"text":"devrun: started","stream":"stdout","timestamp":"1591336122.115481"}}
{"devFileCommandExecutionComplete":{"commandId":"devrun","componentName":"runtime","commandLine":"nodemon app.js","groupKind":"run","timestamp":"1591336122.121467"}}

[openshift-ci-robot]

Hi @jgwest. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jgwest]

/area devfile

[johnmcollier]

/ok-to-test

[jgwest]

/retest

[codecov]

Codecov Report

Merging #3003 into master will decrease coverage by 0.00%.
The diff coverage is 42.42%.

@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   46.16%   46.15%   -0.01%     
==========================================
  Files         112      112              
  Lines       11191    11205      +14     
==========================================
+ Hits         5166     5172       +6     
- Misses       5529     5533       +4     
- Partials      496      500       +4     

Impacted Files	Coverage Δ
pkg/component/component.go	26.40% <0.00%> (ø)
...g/devfile/adapters/kubernetes/component/adapter.go	29.75% <31.25%> (+0.39%)	⬆️
pkg/devfile/adapters/docker/component/utils.go	69.50% <50.00%> (-0.23%)	⬇️
pkg/sync/adapter.go	81.30% <50.00%> (ø)
pkg/devfile/adapters/docker/component/adapter.go	73.80% <62.50%> (-1.20%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd349de...6c0eae8. Read the comment docs.

[jgwest]

/retest

[jgwest]

/retest

[jgwest]

/retest

[jgwest]

/retest

[johnmcollier]

Left some review comments

Also, it seems that at least some errors from the CLI are getting swallowed. E.g. If I set the pushtarget to Docker, but stop Docker:

Johns-MacBook-Pro-3:nodejs johncollier$ odo push
 ✗  Unable to retrieve Docker containers: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

Validation
 ✓  Validating the devfile [48200ns]
 ✗  Failed to start component with name nodejs.
Error: Failed to create the component: unable to retrieve supervisord volume for component nodejs: unable to get list of docker volumes: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

And with -o json:

Johns-MacBook-Pro-3:nodejs johncollier$ odo push -f -o json
Johns-MacBook-Pro-3:nodejs johncollier$ 

[jgwest]

/retest

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[jgwest]

/retest

[johnmcollier]

Readding label due to rebase

/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.