Adds exec command for devfile components with kube push target #3083

mik-dass · 2020-05-05T13:31:01Z

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

Adds a odo exec command which executes a user given command for components with kube push targets.

Which issue(s) this PR fixes:

Fixes #2857

How to test changes / Special notes to the reviewer:

push a devfile component with a kube push target
execute odo exec -- ls <valid_command> and the valid command should be executed in the pod.

mik-dass · 2020-05-05T13:40:31Z

error: some steps failed:
  * could not run steps: step src failed: could not wait for build: the build src failed after 1m17s with reason DockerBuildFailed: Dockerfile build strategy has failed.
{"command":"git merge --no-ff ee37a0122275d1c08cc9eea924dc...ot something we can merge\n","time":"2020-05-05T13:35:29Z"}
{"component":"clonerefs","error":"one or more of the recor..."msg":"Failed to clone refs","time":"2020-05-05T13:35:29Z"}
subprocess exited with status 1
subprocess exited with status 1

/retest

codecov · 2020-05-11T06:33:32Z

Codecov Report

Merging #3083 into master will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3083      +/-   ##
==========================================
- Coverage   46.27%   46.13%   -0.15%     
==========================================
  Files         112      112              
  Lines       11386    11422      +36     
==========================================
  Hits         5269     5269              
- Misses       5608     5644      +36     
  Partials      509      509

Impacted Files	Coverage Δ
pkg/devfile/adapters/docker/component/adapter.go	`58.13% <0.00%> (-6.38%)`	⬇️
...g/devfile/adapters/kubernetes/component/adapter.go	`30.66% <0.00%> (-2.08%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d69aab...d026b18. Read the comment docs.

adisky · 2020-06-11T10:37:54Z

pkg/devfile/adapters/docker/component/adapter.go

+		return errors.Wrapf(err, "error while retrieving container for odo component %s", a.ComponentName)
+	}
+
+	runCommand, err := common.GetRunCommand(a.Devfile.Data, "")


How we will handle here, if runCommand was passed as an odo flag --run-command during odo push?
Same problem i am getting for odo log

We can add a flag for that. But during the discussion, we decided to go with the default container and command for now and implement that later.

Any update on this?

But during the discussion, we decided to go with the default container and command for now and implement that later.

We had decided to use the default run container during the discussion.

adisky · 2020-06-15T07:44:43Z

pkg/odo/cli/component/exec.go

+	namespace        string
+
+	command         []string
+	EnvSpecificInfo *envinfo.EnvSpecificInfo


why additionally using EnvSpecificInfo? we have it in context inside ComponentOptions?
(not specific for your PR, it is duplicate at other places as well)

adisky

@mik-dass if i run odo exec outside context dir, It gives error ✗ open /home/**/devfile.yaml: no such file or directory. can we wrap this error to component not found, Please run odo exec from component directory or use odo create to create a component.

adisky · 2020-07-07T10:34:01Z

pkg/odo/cli/component/exec.go

+// ExecRecommendedCommandName is the recommended exec command name
+const ExecRecommendedCommandName = "exec"
+
+var execExample = ktemplates.Examples(`  # Executes a command inside the component


can we give some examples here? currently it shows

Examples: # Executes a command inside the component odo exec

adisky · 2020-07-07T10:41:08Z

pkg/odo/cli/component/exec.go

+// Complete completes exec args
+func (eo *ExecOptions) Complete(name string, cmd *cobra.Command, args []string) (err error) {
+	if cmd.ArgsLenAtDash() <= -1 {
+		return fmt.Errorf("no command was given for the exec command")


could we elaborate error message here
command not provided
please provide a command to execute, odo exec -- <command to be executed>

mik-dass · 2020-07-07T15:13:50Z

@adisky Fixed.

adisky · 2020-07-09T10:09:25Z

.travis.yml

@@ -138,6 +138,7 @@ jobs:
        - travis_wait make test-cmd-devfile-watch
        - travis_wait make test-cmd-devfile-delete
        - travis_wait make test-cmd-devfile-registry
+        - travis_wait make test-cmd-devfile-exec


update name for the test as well

adisky · 2020-07-09T10:09:36Z

.travis.yml

@@ -165,6 +166,7 @@ jobs:
        - travis_wait make test-cmd-docker-devfile-catalog
        - travis_wait make test-cmd-docker-devfile-delete
        - travis_wait make test-cmd-docker-devfile-url
+        - travis_wait make test-cmd-docker-devfile-exec


adisky · 2020-07-09T10:09:44Z

.travis.yml

@@ -196,5 +198,6 @@ jobs:
        - travis_wait make test-cmd-devfile-watch
        - travis_wait make test-cmd-devfile-push
        - travis_wait make test-cmd-devfile-debug
+        - travis_wait make test-cmd-devfile-exec


adisky · 2020-07-09T10:12:49Z

pkg/devfile/adapters/kubernetes/component/adapter.go

+	if err != nil {
+		return errors.Wrapf(err, "unable to get pod for component %s", a.ComponentName)
+	}
+


shouldn't we check running status for pod?

mik-dass · 2020-07-09T11:35:53Z

@adisky Fixed

mik-dass · 2020-07-13T06:30:47Z

gosec -severity medium -confidence medium -exclude G304,G204 -quiet  ./...
golangci-lint run ./... --timeout 5m
make[1]: golangci-lint: Command not found

/retest

adisky · 2020-07-14T10:05:31Z

@mik-dass check the tests, other than it looks good to me
/lgtm

mik-dass · 2020-07-14T11:39:01Z

error: unable to read URL "https://raw.githubusercontent.com/openshift/library/master/arch/x86_64/community/wildfly/imagestreams/wildfly-centos7.json", server reported 500 Internal Server Error, status code=500

/retest

mik-dass · 2020-07-14T14:36:22Z

[odo]  ✗  Waiting for component to start [4m] [WARNING x5: FailedAttachVolume]
Deleting project: fhyfofhhol

/retest

girishramnani · 2020-07-15T08:03:14Z

/approve

openshift-ci-robot · 2020-07-15T08:03:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mik-dass · 2020-07-15T08:54:02Z

  * could not initialize namespace: could not create role binding for: rolebindings.rbac.authorization.k8s.io is forbidden: User "system:serviceaccount:ci:ci-operator" cannot create resource "rolebindings" in API group "rbac.authorization.k8s.io" in the namespace "ci-op-5h225d4z"

/retest

openshift-bot · 2020-07-15T09:02:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels May 5, 2020

openshift-ci-robot requested review from dharmit and girishramnani May 5, 2020 13:31

mik-dass force-pushed the exec_dev branch from ee37a01 to 0c87de7 Compare May 5, 2020 13:35

mik-dass force-pushed the exec_dev branch from 0c87de7 to 10e51ff Compare May 5, 2020 15:24

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 6, 2020

mik-dass force-pushed the exec_dev branch from 10e51ff to bc1dbde Compare May 6, 2020 05:35

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. labels May 6, 2020

mik-dass force-pushed the exec_dev branch from bc1dbde to 78ecb6a Compare May 11, 2020 03:56

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 11, 2020

mik-dass force-pushed the exec_dev branch from 78ecb6a to 69b0db9 Compare May 11, 2020 07:10

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 12, 2020

mik-dass force-pushed the exec_dev branch from 69b0db9 to a8e9380 Compare May 13, 2020 06:39

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label May 13, 2020

mik-dass force-pushed the exec_dev branch from a8e9380 to 535a19f Compare May 13, 2020 06:47

mik-dass force-pushed the exec_dev branch 3 times, most recently from 15bb2aa to 26bf3cb Compare June 10, 2020 07:45

mik-dass changed the title ~~[WIP] Adds exec command for devfile components with kube push target~~ Adds exec command for devfile components with kube push target Jun 10, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 10, 2020

mik-dass force-pushed the exec_dev branch from 26bf3cb to 3fdf20d Compare June 10, 2020 10:32

adisky reviewed Jun 11, 2020

View reviewed changes

adisky reviewed Jun 15, 2020

View reviewed changes

mik-dass force-pushed the exec_dev branch 3 times, most recently from a8abe66 to be1505c Compare June 15, 2020 15:15

adisky reviewed Jul 7, 2020

View reviewed changes

mik-dass force-pushed the exec_dev branch from bb88049 to 9e09c5e Compare July 7, 2020 15:13

adisky reviewed Jul 9, 2020

View reviewed changes

mik-dass force-pushed the exec_dev branch from 9e09c5e to 101610b Compare July 9, 2020 11:31

mik-dass added 5 commits July 13, 2020 10:34

Adds exec command for devfile components with kube push target

0effaf7

Adds comments

fd99524

Modifies tests to run on kubernetes clusters

009d131

Modifies exec logic to use GetPodUsingComponentName()

fec4da5

Fixes context directory detection, adds comments and fixes the example

e8c2b3b

mik-dass force-pushed the exec_dev branch from 65e52d9 to 8e116b7 Compare July 13, 2020 05:14

Updates names of the Travis tests

d026b18

mik-dass force-pushed the exec_dev branch from 8e116b7 to d026b18 Compare July 13, 2020 05:21

openshift-ci-robot assigned adisky Jul 14, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 14, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 15, 2020

adisky mentioned this pull request Jul 15, 2020

Execute devfile commands other than build and run #2754

Closed

2 tasks

openshift-merge-robot merged commit 9be483f into redhat-developer:master Jul 15, 2020

mik-dass deleted the exec_dev branch July 15, 2020 11:29

GeekArthur mentioned this pull request Jul 30, 2020

Remove --devfile parameter from non odo create commands. #3661

Closed

snyk-bot mentioned this pull request Sep 18, 2021

[Snyk] Security upgrade prismjs from 1.24.0 to 1.25.0 adamkeinan/odo#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds exec command for devfile components with kube push target #3083

Adds exec command for devfile components with kube push target #3083

mik-dass commented May 5, 2020 •

edited

mik-dass commented May 5, 2020

codecov bot commented May 11, 2020 •

edited

adisky Jun 11, 2020 •

edited

mik-dass Jun 11, 2020

girishramnani Jul 2, 2020

mik-dass Jul 3, 2020

adisky Jun 15, 2020

mik-dass Jun 15, 2020

adisky left a comment

adisky Jul 7, 2020

adisky Jul 7, 2020

mik-dass commented Jul 7, 2020

adisky Jul 9, 2020

adisky Jul 9, 2020

adisky Jul 9, 2020

adisky Jul 9, 2020

mik-dass commented Jul 9, 2020

mik-dass commented Jul 13, 2020

adisky commented Jul 14, 2020

mik-dass commented Jul 14, 2020

mik-dass commented Jul 14, 2020

girishramnani commented Jul 15, 2020

openshift-ci-robot commented Jul 15, 2020

mik-dass commented Jul 15, 2020

openshift-bot commented Jul 15, 2020

Adds exec command for devfile components with kube push target #3083

Adds exec command for devfile components with kube push target #3083

Conversation

mik-dass commented May 5, 2020 • edited

mik-dass commented May 5, 2020

codecov bot commented May 11, 2020 • edited

Codecov Report

adisky Jun 11, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adisky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mik-dass commented Jul 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mik-dass commented Jul 9, 2020

mik-dass commented Jul 13, 2020

adisky commented Jul 14, 2020

mik-dass commented Jul 14, 2020

mik-dass commented Jul 14, 2020

girishramnani commented Jul 15, 2020

openshift-ci-robot commented Jul 15, 2020

mik-dass commented Jul 15, 2020

openshift-bot commented Jul 15, 2020

mik-dass commented May 5, 2020 •

edited

codecov bot commented May 11, 2020 •

edited

adisky Jun 11, 2020 •

edited