Fix #2707 : `odo catalog list components -o json` does not have `imageStreamRef` in json output after update from v1.0.x to v1.1.0 #3226

devang-gaur · 2020-05-20T21:06:55Z

What type of PR is this?

/kind bug

What does this PR do / why we need it:
Undoes the change made/bug added in PR #2451

Which issue(s) this PR fixes:
Fixes #2707

dharmit · 2020-05-21T12:34:55Z

/test v4.3-integration-e2e
Looks like infra issue:

level=fatal msg="failed to fetch Cluster: failed to fetch dependency of \"Cluster\": failed to generate asset \"Platform Permissions Check\": validate AWS credentials: checking install permissions: error simulating policy: Throttling: Rate exceeded\n\tstatus code: 400, request id: 065d512a-bdb8-4093-b8af-4fd188aa55b7"

dharmit · 2020-05-21T12:35:30Z

/approve

openshift-ci-robot · 2020-05-21T12:36:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/catalog/OWNERS~~ [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prietyc123 · 2020-05-22T08:14:26Z

Flake https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3226/pull-ci-openshift-odo-master-v4.3-integration-e2e/563#1:build-log.txt%3A551

Issue tracked #3193

/retest

dharmit · 2020-05-29T06:45:32Z

Looks like connecting to devfile registry failed.
/test v4.5-integration-e2e

 [odo] I0526 11:16:31.969509    6263 util.go:399] path ./.odo/config.yaml doesn't exist, skipping it
[odo] I0526 11:16:31.969525    6263 preference.go:188] The path for preference file is /tmp/318979902/config.yaml
[odo] I0526 11:16:31.975008    6263 preference.go:188] The path for preference file is /tmp/318979902/config.yaml
[odo]  ⚠  Registry CheDevfileRegistry is not set up properly with error: Unable to download the devfile from https://che-devfile-registry.openshift.io/devfiles/angular/devfile.yaml: Get https://che-devfile-registry.openshift.io/devfiles/angular/devfile.yaml: net/http: timeout awaiting response headers
[odo]  ⚠  Registry CheDevfileRegistry is not set up properly with error: Unable to download the devfile from https://che-devfile-registry.openshift.io/devfiles/java-gradle/devfile.yaml: Get https://che-devfile-registry.openshift.io/devfiles/java-gradle/devfile.yaml: net/http: timeout awaiting response headers
[odo]  ✗  Get https://che-devfile-registry.openshift.io/devfiles/angular/devfile.yaml: net/http: timeout awaiting response headers
Deleting project: ydzppjstcg
Running odo with args [odo project delete ydzppjstcg -f]
[odo] I0526 11:16:46.256037    6400 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "ydzppjstcg"
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0526 11:16:46.356821    6400 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Deleted project : ydzppjstcg
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration/devfile
Deleting dir: /tmp/318979902
• Failure [16.700 seconds]
odo devfile delete command tests
/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_delete_test.go:14
  when devfile delete command is executed
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_delete_test.go:46
    should delete the component created from the devfile and also the owned resources [It]
[odo]  ✓  Deleted project : vfqzcvhsgm
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration/devfile
Deleting dir: /tmp/571707124

4.3 failure is fixed by #3239.
/test v4.3-integration-e2e

dharmit · 2020-05-29T06:46:56Z

/lgtm since it's a one-line fix simply undoing what was done in #2451.

dharmit · 2020-06-01T11:46:28Z

4.3 integration test fails with:

 • Failure [42.928 seconds]
odo debug command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:18
  odo debug on a nodejs:latest component
  /go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:41
    check that machine output debug information works [It]
    /go/src/github.com/openshift/odo/tests/integration/cmd_debug_test.go:42
    No future change is possible.  Bailing out early after 0.765s.
      
    Running odo with args [odo debug info --context /tmp/242064143 -o json]
    Expected
        <int>: 1
    to match exit code:
        <int>: 0

Cause of failure:

Running odo with args [odo debug info --context /tmp/242064143 -o json]
[odo] Started port forwarding at ports - 45860:5858
[odo] {
[odo]     "kind": "Error",
[odo]     "apiVersion": "odo.dev/v1alpha1",
[odo]     "metadata": {
[odo]         "creationTimestamp": null
[odo]     },
[odo]     "message": "debug is not running for the component nodejs-242064143-svih"
[odo] }

Opened #3273 since it's showing up with same tracebacks.

/test v4.3-integration-e2e

dharmit · 2020-06-02T09:52:27Z

#3122 - link to logs

 [odo]  ✗  Failed to start component with name pjqkmu.
[odo] Error: Failed to create the component: unable to create or update component: unable to create Deployment pjqkmu: deployments.apps "pjqkmu" is forbidden: unable to create new content in namespace ybhcrgeoif because it is being terminated
Deleting project: bldnwdtvva
Running odo with args [odo project delete bldnwdtvva -f]
[odo] I0601 13:39:05.327060    5614 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: serviceinstances.servicecatalog.k8s.io is forbidden: User "developer" cannot list resource "serviceinstances" in API group "servicecatalog.k8s.io" in the namespace "bldnwdtvva"
[odo]  ⚠  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project may still exist on a different node.
[odo] I0601 13:39:05.409894    5614 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
[odo]  ✓  Deleted project : bldnwdtvva
Setting current dir to: /go/src/github.com/openshift/odo/tests/integration/devfile
Deleting dir: /tmp/266381801
• Failure [3.527 seconds]
odo devfile url command tests
/go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_url_test.go:16
  Creating urls
  /go/src/github.com/openshift/odo/tests/integration/devfile/cmd_devfile_url_test.go:105
    create with now flag should pass [It]
[Fail] odo devfile url command tests Creating urls [It] create with now flag should pass 
/go/src/github.com/openshift/odo/tests/helper/helper_run.go:34
Ran 59 of 59 Specs in 576.181 seconds
FAIL! -- 58 Passed | 1 Failed | 0 Pending | 0 Skipped

/test v4.3-integration-e2e

codecov · 2020-06-02T12:10:03Z

Codecov Report

Merging #3226 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   45.57%   45.56%   -0.01%     
==========================================
  Files         111      111              
  Lines       10972    10972              
==========================================
- Hits         5000     4999       -1     
- Misses       5483     5484       +1     
  Partials      489      489

Impacted Files	Coverage Δ
pkg/catalog/catalog.go	`50.44% <100.00%> (ø)`
pkg/sync/sync.go	`47.52% <0.00%> (-1.00%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8faf7e5...8171029. Read the comment docs.

girishramnani · 2020-06-03T10:22:40Z

/hold

kadel · 2020-06-03T12:35:09Z

/hold

why?

girishramnani · 2020-06-10T08:00:16Z

@kadel #2707 (comment)

girishramnani · 2020-06-10T08:01:34Z

@dev-gaur can you add the change as discussed here #2707 (comment)

girishramnani · 2020-06-11T06:22:20Z

pkg/catalog/catalog.go

@@ -443,7 +443,7 @@ func SliceSupportedTags(component ComponentType) ([]string, []string) {

 	// this makes sure that json marshal shows these lists as [] instead of null
 	supTag, unSupTag := []string{}, []string{}
-	tagMap := createImageTagMap(component.Spec.ImageStreamRef.Spec.Tags)
+	tagMap := createImageTagMap(component.Spec.ImageStreamTags)


Don’t change this

Or on second thought, let’s see the tests

…d of ImageStream

devang-gaur · 2020-06-11T12:49:14Z

The json output we get now outputs the ImageStreamTags...

@dgolovin I think the info you require can be found at the .item[i].spec.imageStreamTags path

[dev-gaur@R3L-srv nodejs-ex]$ ./odo catalog list components -o json
{
    "kind": "List",
    "apiVersion": "odo.dev/v1alpha1",
    "metadata": {
        "creationTimestamp": null
    },
    "items": [
        {
            "kind": "ComponentType",
            "apiVersion": "odo.dev/v1alpha1",
            "metadata": {
                "name": "dotnet",
                "namespace": "openshift",
                "creationTimestamp": null
            },
            "spec": {
                "allTags": [
                    "2.1",
                    "2.2",
                    "latest"
                ],
                "nonHiddenTags": [
                    "2.1",
                    "2.2",
                    "latest"
                ],
                "supportedTags": [],
                "imageStreamTags": [
                    {
                        "name": "2.1",
                        "annotations": {
                            "description": "Build and run .NET Core 2.1 applications on RHEL 7. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/master/2.1/build/README.md.",
                            "iconClass": "icon-dotnet",
                            "openshift.io/display-name": ".NET Core 2.1",
                            "sampleContextDir": "app",
                            "sampleRef": "dotnetcore-2.1",
                            "sampleRepo": "https://github.com/redhat-developer/s2i-dotnetcore-ex.git",
                            "supports": "dotnet:2.1,dotnet",
                            "tags": "builder,.net,dotnet,dotnetcore,rh-dotnet21",
                            "version": "2.1"
                        },
                        "from": {
                            "kind": "DockerImage",
                            "name": "registry.redhat.io/dotnet/dotnet-21-rhel7:2.1"
                        },
                        "generation": 2,
                        "importPolicy": {},
                        "referencePolicy": {
                            "type": "Local"
                        }
                    },
                    {
                        "name": "2.2",
                        "annotations": {
                            "description": "Build and run .NET Core 2.2 applications on RHEL 7. For more information about using this builder image, including OpenShift considerations, see https://github.com/redhat-developer/s2i-dotnetcore/tree/master/2.2/build/README.md.",
                            "iconClass": "icon-dotnet",
                            "openshift.io/display-name": ".NET Core 2.2",
                            "sampleContextDir": "app",
                            "sampleRef": "dotnetcore-2.2",
                            "sampleRepo": "https://github.com/redhat-developer/s2i-dotnetcore-ex.git",
                            "supports": "dotnet:2.2,dotnet",
                            "tags": "builder,.net,dotnet,dotnetcore,rh-dotnet22",
                            "version": "2.2"
                        },
                        "from": {
                            "kind": "DockerImage",
                            "name": "registry.redhat.io/dotnet/dotnet-22-rhel7:2.2"
                        },
                        "generation": 2,
                        "importPolicy": {},
                        "referencePolicy": {
                            "type": "Local"
                        }
                    },
.....

girishramnani · 2020-07-02T20:03:34Z

/hold cancel

girishramnani · 2020-07-02T20:03:54Z

Please verify if this works @dgolovin

kadel · 2020-07-08T14:15:55Z

/lgtm
/retest

openshift-bot · 2020-07-08T21:42:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-08T21:55:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-07-09T03:07:18Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2020

openshift-ci-robot requested review from dharmit and GeekArthur May 20, 2020 21:07

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label May 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jun 3, 2020

devang-gaur force-pushed the fix#2707 branch from 6b444e3 to dacc227 Compare June 11, 2020 06:10

girishramnani reviewed Jun 11, 2020

View reviewed changes

Edit ComponentSpec type definition to give out ImageStreamTags instea…

8171029

…d of ImageStream

devang-gaur force-pushed the fix#2707 branch from dacc227 to 8171029 Compare June 11, 2020 06:32

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 2, 2020

openshift-ci-robot assigned kadel Jul 8, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 8, 2020

openshift-merge-robot merged commit e6340c9 into redhat-developer:master Jul 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #2707 : `odo catalog list components -o json` does not have `imageStreamRef` in json output after update from v1.0.x to v1.1.0 #3226

Fix #2707 : `odo catalog list components -o json` does not have `imageStreamRef` in json output after update from v1.0.x to v1.1.0 #3226

devang-gaur commented May 20, 2020

dharmit commented May 21, 2020

dharmit commented May 21, 2020

openshift-ci-robot commented May 21, 2020

prietyc123 commented May 22, 2020 •

edited

dharmit commented May 29, 2020

dharmit commented May 29, 2020

dharmit commented Jun 1, 2020

dharmit commented Jun 2, 2020

codecov bot commented Jun 2, 2020 •

edited

girishramnani commented Jun 3, 2020

kadel commented Jun 3, 2020

girishramnani commented Jun 10, 2020

girishramnani commented Jun 10, 2020

girishramnani Jun 11, 2020

girishramnani Jun 11, 2020

devang-gaur commented Jun 11, 2020

girishramnani commented Jul 2, 2020

girishramnani commented Jul 2, 2020

kadel commented Jul 8, 2020

openshift-bot commented Jul 8, 2020

openshift-bot commented Jul 8, 2020

openshift-bot commented Jul 9, 2020

Fix #2707 : odo catalog list components -o json does not have imageStreamRef in json output after update from v1.0.x to v1.1.0 #3226

Fix #2707 : odo catalog list components -o json does not have imageStreamRef in json output after update from v1.0.x to v1.1.0 #3226

Conversation

devang-gaur commented May 20, 2020

dharmit commented May 21, 2020

dharmit commented May 21, 2020

openshift-ci-robot commented May 21, 2020

prietyc123 commented May 22, 2020 • edited

dharmit commented May 29, 2020

dharmit commented May 29, 2020

dharmit commented Jun 1, 2020

dharmit commented Jun 2, 2020

codecov bot commented Jun 2, 2020 • edited

Codecov Report

girishramnani commented Jun 3, 2020

kadel commented Jun 3, 2020

girishramnani commented Jun 10, 2020

girishramnani commented Jun 10, 2020

girishramnani Jun 11, 2020

Choose a reason for hiding this comment

girishramnani Jun 11, 2020

Choose a reason for hiding this comment

devang-gaur commented Jun 11, 2020

girishramnani commented Jul 2, 2020

girishramnani commented Jul 2, 2020

kadel commented Jul 8, 2020

openshift-bot commented Jul 8, 2020

openshift-bot commented Jul 8, 2020

openshift-bot commented Jul 9, 2020

Fix #2707 : `odo catalog list components -o json` does not have `imageStreamRef` in json output after update from v1.0.x to v1.1.0 #3226

Fix #2707 : `odo catalog list components -o json` does not have `imageStreamRef` in json output after update from v1.0.x to v1.1.0 #3226

prietyc123 commented May 22, 2020 •

edited

codecov bot commented Jun 2, 2020 •

edited