Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding latest minikube version on travis #3411

Merged
merged 2 commits into from
Jul 4, 2020
Merged

Adding latest minikube version on travis #3411

merged 2 commits into from
Jul 4, 2020

Conversation

prietyc123
Copy link
Contributor

What type of PR is this?

/kind feature

What does does this PR do / why we need it:

Update minikube version on travis CI

Which issue(s) this PR fixes:

Fixes NA

How to test changes / Special notes to the reviewer:

Minikube should get set up on travis successfully.

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jun 24, 2020
@prietyc123 prietyc123 force-pushed the UpdateLatestMinikubeVersion branch 4 times, most recently from aa6b112 to a85b51f Compare June 24, 2020 08:46
mik-dass
mik-dass approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 24, 2020
@prietyc123
Copy link
Contributor Author

prow failure

/retest

@prietyc123
Copy link
Contributor Author

prow failure

/retest

@codecov
Copy link

codecov bot commented Jun 26, 2020 •
edited

Codecov Report

Merging #3411 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3411      +/-   ##
==========================================
- Coverage   46.50%   46.45%   -0.05%     
==========================================
  Files         112      112              
  Lines       11223    11237      +14     
==========================================
+ Hits         5219     5220       +1     
- Misses       5503     5513      +10     
- Partials      501      504       +3
Impacted Files Coverage Δ
pkg/sync/sync.go 43.56% <0.00%> (-4.96%) ⬇️
pkg/devfile/adapters/kubernetes/utils/utils.go 52.48% <0.00%> (-1.93%) ⬇️
pkg/devfile/adapters/docker/component/utils.go 68.83% <0.00%> (-0.68%) ⬇️
...g/devfile/adapters/kubernetes/component/adapter.go 29.62% <0.00%> (-0.13%) ⬇️
pkg/lclient/client.go 0.00% <0.00%> (ø)
pkg/lclient/fakeclient.go 82.11% <0.00%> (ø)
pkg/devfile/adapters/common/types.go 100.00% <0.00%> (ø)
pkg/devfile/adapters/docker/component/adapter.go 74.01% <0.00%> (+0.20%) ⬆️
pkg/sync/adapter.go 82.88% <0.00%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3df6f0a...d3909b0. Read the comment docs.

girishramnani
girishramnani reviewed Jul 1, 2020
View reviewed changes
.travis.yml Outdated
# Download minikube and set up Kubernetes single node cluster
- curl -Lo minikube https://storage.googleapis.com/minikube/releases/v1.4.0/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
- curl -Lo minikube https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 && chmod +x minikube && sudo mv minikube /usr/local/bin/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to pin down the minikube version instead of using latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently latest release of minikube is v1.11.0. So I will update this version in the script. Thanks

@girishramnani
Copy link
Contributor

@prietyc123 any update on the comment?

@prietyc123 prietyc123 force-pushed the UpdateLatestMinikubeVersion branch from a85b51f to d3909b0 Compare July 3, 2020 07:06
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 3, 2020
@prietyc123
Copy link
Contributor Author

@prietyc123 any update on the comment?

#3411 (comment)

mik-dass
mik-dass approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 3, 2020
@prietyc123
Copy link
Contributor Author

Prow failure

/retest

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit c4186eb into redhat-developer:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girishramnani girishramnani girishramnani left review comments

@mik-dass mik-dass mik-dass approved these changes

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prietyc123 @girishramnani @openshift-ci-robot @mik-dass @openshift-merge-robot