Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3380: odo create --help should mention odo catalog list components instead of odo catalog list #3419

Merged
merged 1 commit into from
Jul 3, 2020
Merged

fix #3380: odo create --help should mention odo catalog list components instead of odo catalog list #3419

merged 1 commit into from
Jul 3, 2020

Conversation

devang-gaur
Copy link
Contributor

@devang-gaur devang-gaur commented Jun 25, 2020 •
edited

/kind bug

Fixes #3380

How to test changes / Special notes to the reviewer:
odo create --help should mention odo catalog list components instead of odo catalog list.

@devang-gaur devang-gaur requested a review from kadel June 25, 2020 12:13
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 25, 2020
dharmit
dharmit suggested changes Jun 25, 2020
View reviewed changes
Copy link
Member

@dharmit dharmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to approve & lgtm this right away but for one minor thing. Can you please modify the PR's title to indicate what it's fixing? I'm asking this because that's the message that actually shows up when we do "git log". And, IMO, it's more helpful to know what's being fixed. The error is already documented in the issue.

Let me know if that doesn't sound reasonable and I'll approve + lgtm it right away.

@devang-gaur devang-gaur changed the title fix #3380:"odo catalog list" leads to error, but is suggested in "odo… fix #3380: odo create --help should mention odo catalog list components instead of odo catalog list Jun 25, 2020
mik-dass
mik-dass approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 25, 2020
@mik-dass
Copy link
Contributor

I'm asking this because that's the message that actually shows up when we do "git log"

I guess @dharmit also means updating the git log message.

@mik-dass
Copy link
Contributor

Gosec has error fixed upstream so our unit tests should not error out
securego/gosec@3784ffe

/retest

@devang-gaur
fix redhat-developer#3380: odo create --help should mention `odo ca…
e94125d 
…talog list components` instead of `odo catalog list`
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 29, 2020
@devang-gaur devang-gaur requested a review from dharmit June 29, 2020 20:43
@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited

Codecov Report

Merging #3419 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3419   +/-   ##
=======================================
  Coverage   46.48%   46.49%           
=======================================
  Files         112      112           
  Lines       11223    11223           
=======================================
+ Hits         5217     5218    +1     
+ Misses       5505     5504    -1     
  Partials      501      501
Impacted Files Coverage Δ
pkg/sync/sync.go 47.52% <0.00%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67da8a1...e94125d. Read the comment docs.

@dharmit
Copy link
Member

dharmit commented Jul 1, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 1, 2020
@girishramnani
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@girishramnani
Copy link
Contributor

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3df6f0a into redhat-developer:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@kadel kadel Awaiting requested review from kadel

@girishramnani girishramnani Awaiting requested review from girishramnani

@dharmit dharmit Awaiting requested review from dharmit

Assignees

@dharmit dharmit

@girishramnani girishramnani

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"odo catalog list" leads to error, but is suggested in "odo create --help"
7 participants
@devang-gaur @mik-dass @dharmit @openshift-ci-robot @girishramnani @openshift-bot @openshift-merge-robot