-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure registry support #3516
Secure registry support #3516
Conversation
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some review comments.
Could you also update Odo's documentation to add instructions for the following:
- Adding a secured registry
- Github token requirements (what permissions are needed)
- Keyring setup (esp. on Linux)
@GeekArthur As a heads up, the
|
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Thanks @johnmcollier for reviewing this PR quickly, I will update the corresponding instructions for odo docs in another PR. I will push commits to fix the tests and address all comments that I can resolve, and leave the open questions as unresolved comments. |
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@johnmcollier All comments are addressed, please review again. The following things still need to finish:
|
/assign |
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good to me, since we'll be handling the docs in a separate PR.
Left a couple more comments, mostly nits.
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@johnmcollier Comments addressed, please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Codecov Report
@@ Coverage Diff @@
## master #3516 +/- ##
==========================================
- Coverage 46.47% 46.27% -0.20%
==========================================
Files 112 113 +1
Lines 11244 11420 +176
==========================================
+ Hits 5226 5285 +59
- Misses 5513 5622 +109
- Partials 505 513 +8
Continue to review full report at Codecov.
|
Signed-off-by: jingfu wang jingfu.j.wang@ibm.com
What type of PR is this?
/kind feature
/area devfile
What does does this PR do / why we need it:
The PR implements the secure registry feature which user can use odo to interact with private/secure registry.
Design proposal: #3329
Which issue(s) this PR fixes:
Fixes #2893
**How to test changes:
repo
access scope from your GitHub accountodo registry add <registry name> <registry URL> --token <token>
to add secure registryodo catalog list components
to list available components from secure registryodo create <component type> --registry <registry name>
to create component from secure registryodo registry delete <registry name>
to delete secure registryNote: you can also test
odo registry update <registry name> <registry URL> --token <token>
to update secure registry once you already create the registrySpecial notes to the reviewer:
token
for authentication/authorization as there is no use case to useusername/password