Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete context on Windows #3535

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fix delete context on Windows #3535

merged 1 commit into from
Jul 10, 2020

Conversation

amitkrout
Copy link
Contributor

What type of PR is this?

/kind bug

Which issue(s) this PR fixes:

Fixes #3534

How to test changes / Special notes to the reviewer:
make test-cmd-devfile-debug should pass on Windows platform too

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 9, 2020
amitkrout
amitkrout commented Jul 9, 2020
View reviewed changes
tests/integration/devfile/debug/cmd_devfile_debug_test.go
@@ -62,9 +62,6 @@ var _ = Describe("odo devfile debug command serial tests", func() {
})

It("should auto-select a local debug port when the given local port is occupied for a devfile component", func() {
// Devfile push requires experimental mode to be set
helper.CmdShouldPass("odo", "preference", "set", "Experimental", "true", "-f")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unnecessary. Already set in the teardown steps

@amitkrout
Copy link
Contributor Author

Verified on Windows

PS C:\Users\Admin\go\src\github.com\openshift\odo> make test-cmd-devfile-debug
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo devfile debug command tests" tests/integration/devfile/
[1] Running Suite: Devfile Suite
[1] ============================
[1] Random Seed: 1594312255 - Will randomize all specs
[1] Parallel test node 1/2.
[1]
[2] Running Suite: Devfile Suite
[2] ============================
[2] Random Seed: 1594312255 - Will randomize all specs
[2] Parallel test node 2/2.
[2]
[1] SSSSSSSSS+SSSSS
SSSS+SSSSSSSSSSSSSS

[1] Ran 2 of 31 Specs in 28.032 seconds
[1] SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 29 Skipped
[1] PASS
[2] SSSSSSSSSSSSSSS
SSSSSSSSSSSSSSSSSSS
SSSSSSSSSSSSSSSSS
SSSSSSSS+SSSS+
[2] Ran 2 of 60 Specs in 31.830 seconds
[2] SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 58 Skipped
[2] PASS

Ginkgo ran 1 suite in 46.5162337s
Test Suite Passed
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=1 -focus="odo devfile debug command serial tests" tests/integration/devfile/debug   
Running Suite: Debug Suite
==========================
Random Seed: 1594312302 - Will randomize all specs
Will run 1 of 1 specs

+
Ran 1 of 1 Specs in 13.193 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

Ginkgo ran 1 suite in 19.5567382s
Test Suite Passed
PS C:\Users\Admin\go\src\github.com\openshift\odo>

mik-dass
mik-dass approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020 •
edited

Codecov Report

Merging #3535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3535   +/-   ##
=======================================
  Coverage   46.18%   46.18%           
=======================================
  Files         112      112           
  Lines       11333    11333           
=======================================
  Hits         5234     5234           
  Misses       5593     5593           
  Partials      506      506

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9ebc8c...4631bd3. Read the comment docs.

@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit 632c040 into redhat-developer:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@adisky adisky Awaiting requested review from adisky

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-cmd-devfile-debug teardown steps throws error while deleting context on windows platform
5 participants
@amitkrout @girishramnani @openshift-ci-robot @mik-dass @openshift-merge-robot