Fixing location field for odo catalog describe component jave-openliberty #3538
Conversation
openshift-ci-robot
added
the
kind/bug
|
Pr odo-devfiles/registry#17 breaking our master. BTW i am working on the issue #3378 which will prevent such unpleasant situation in future. Till then please have patience. |
|
@prietyc123 Thanks for the pr |
| @@ -91,7 +91,7 @@ var _ = Describe("odo devfile catalog command tests", func() { | |||
| Context("When executing catalog describe component with a component name with a single project", func() { | |||
| It("should only give information about one project", func() { | |||
| output := helper.CmdShouldPass("odo", "catalog", "describe", "component", "java-openliberty") | |||
| helper.MatchAllInOutput(output, []string{"location: https://github.com/odo-devfiles/openliberty-ex.git"}) | |||
| helper.MatchAllInOutput(output, []string{"location: https://github.com/OpenLiberty/application-stack.git"}) | |||
There was a problem hiding this comment.
This should ideally match for someting that doesn't depend on content of the devfile.
For for the following regexp location: .+
Expect(output).To(MatchRegexp("location: .+"))
There was a problem hiding this comment.
Expect(output).To(MatchRegexp("location: .+"))
+1
|
/approve |
openshift-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@prietyc123: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Test platform failure on 4.2 cluster unnecessarily killing our time. I am merging it to unblock other pr from failure. BTW test passed on 4.3, 4.4 and 4.5 cluster. |
can we try to do something with 4.2 tests? |
What type of PR is this?
/kind bug
What does does this PR do / why we need it:
$SUBJECT which is breaking CI https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/openshift_odo/3523/pull-ci-openshift-odo-master-v4.5-integration-e2e/1281448634201673728#1:build-log.txt%3A567
Which issue(s) this PR fixes:
Fixes NA
How to test changes / Special notes to the reviewer:
It should solve the CI break issue for
odo catalog describe component jave-openliberty