Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change service list output to make linking easier #3561

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Change service list output to make linking easier #3561

merged 1 commit into from
Jul 14, 2020

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Jul 14, 2020

What type of PR is this?
/kind code-refactoring
/area UX

What does does this PR do / why we need it:
It changes the way odo service list prints the output.

Which issue(s) this PR fixes:

Fixes #3560

How to test changes / Special notes to the reviewer:
Start a few Operator backed services and execute odo service list. Output should be of the format:

$ odo service list
NAME                          AGE
Cockroachdb/example           3s
EtcdCluster/example           3m22s
EtcdCluster/myawesomeetcd     3s

@openshift-ci-robot openshift-ci-robot added kind/code-refactoring area/UX Issues or PRs related to User Experience labels Jul 14, 2020
@kadel
Copy link
Member

kadel commented Jul 14, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Jul 14, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #3561 into master will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3561      +/-   ##
==========================================
- Coverage   46.27%   46.06%   -0.21%     
==========================================
  Files         112      113       +1     
  Lines       11386    11437      +51     
==========================================
  Hits         5269     5269              
- Misses       5608     5659      +51     
  Partials      509      509              
Impacted Files Coverage Δ
pkg/odo/cli/service/list.go 0.00% <0.00%> (ø)
pkg/preference/machine_output.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdea76f...c83ae78. Read the comment docs.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ebf1dcf into redhat-developer:master Jul 14, 2020
@dharmit dharmit deleted the fix-3560 branch April 18, 2022 08:45
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring area/UX Issues or PRs related to User Experience lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"odo service list" should output Operator backed service as "<servicekind>/<servicename>"
6 participants