Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trunicate longer devfile description #4150

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Trunicate longer devfile description #4150

merged 4 commits into from
Oct 29, 2020

Conversation

mohammedzee1000
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 commented Oct 26, 2020 •
edited

What type of PR is this?

/kind feature

What does this PR do / why we need it:
This PR updates existing util function to trunicate string to allow you to specify and append value (updating existing refs along the way) and then used updated function to trunicate devfile component description, appending ... if truncation is done

Which issue(s) this PR fixes:

Fixes #4044

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Build odo from here this code and then:

❯ ./odo registry list
NAME                       URL                                           SECURE
CheRegistry                https://che-devfile-registry.openshift.io     No
DefaultDevfileRegistry     https://github.com/odo-devfiles/registry      No

❯ ./odo catalog list components
Odo Devfile Components:
NAME                 DESCRIPTION                                                         REGISTRY
                     Stack for developing NodeJS Angular Web Application                 CheRegistry
                     Stack with tooling ready to develop Integration projects wit...     CheRegistry
                     Stack with environment ready to develop Integration projects...     CheRegistry
                     Che4z Mainframe Basic Stack is an all-in-one extension pack ...     CheRegistry
                     Stack with C/C++ and Clang 8                                        CheRegistry
                     Stack with .Net 3.1                                                 CheRegistry
                     Stack for developing ASP.NET Core Web Application                   CheRegistry
                     Stack with Go 1.12.10                                               CheRegistry
                     Java Stack with OpenJDK 11 and Gradle 6.2.1                         CheRegistry
                     Java Stack with OpenJDK 11 and Maven 3.6.0                          CheRegistry
                     Java stack with OpenJDK 8, MongoDB and Spring Boot Guestbook...     CheRegistry
                     Java stack with OpenJDK 8, MySQL and Spring Boot Petclinic d...     CheRegistry
                     Java stack with OpenJDK 11 and Spring Boot Petclinic demo ap...     CheRegistry
                     Java stack with OpenJDK 8 and Vert.x demo application               CheRegistry
                     Stack with NodeJS 10                                                CheRegistry
                     Stack with NodeJS 10 and MongoDB 3.4                                CheRegistry
                     Stack for developing NodeJS React Web Application                   CheRegistry
                     Stack for developing NodeJS Web Application based on Yarn           CheRegistry
                     PHP Stack with Laravel and MySQL real world application             CheRegistry
                     PHP Stack with MySQL and simple database application                CheRegistry
                     PHP Stack with Symfony Demo Application https://symfony.com/        CheRegistry
                     PHP Stack with PHP 7.1 and simple web application                   CheRegistry
                     Python Stack with Python 3.7                                        CheRegistry
                     Python Stack with Python 3.7 and Django application                 CheRegistry
                     Quarkus Stack with OpenJDK 11 and Maven 3.6.3                       CheRegistry
                     Quarkus command mode with OpenJDK 11 and Maven 3.6.3                CheRegistry
                     Rust Stack with Rust 1.39                                           CheRegistry
                     Scala Stack with OpenJDK 11 and sbt 1.x                             CheRegistry
java-maven           Upstream Maven and OpenJDK 11                                       DefaultDevfileRegistry
java-openliberty     Open Liberty microservice in Java                                   DefaultDevfileRegistry
java-quarkus         Upstream Quarkus with Java+GraalVM                                  DefaultDevfileRegistry
java-springboot      Spring Boot® using Java                                             DefaultDevfileRegistry
java-vertx           Upstream Vert.x using Java                                          DefaultDevfileRegistry
nodejs               Stack with NodeJS 12                                                DefaultDevfileRegistry
python               Python Stack with Python 3.7                                        DefaultDevfileRegistry
python-django        Python3.7 with Django                                               DefaultDevfileRegistry

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 26, 2020
@girishramnani
Copy link
Contributor

there is a file called deps.png added to the project

@girishramnani
Copy link
Contributor

please remove it

@mohammedzee1000
Copy link
Contributor Author

wow how did that get in o_O

@mohammedzee1000
Copy link
Contributor Author

Removed

@kadel
Copy link
Member

kadel commented Oct 26, 2020

/retest

@mohammedzee1000
Copy link
Contributor Author

/test v4.5-integration-e2e

@girishramnani girishramnani requested review from girishramnani and removed request for johnmcollier October 27, 2020 14:09
@mohammedzee1000
SD
1fafdf6 
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@mohammedzee1000
Updating trunicate func to allow trimming and trimming component desc
e89f8c4 
 - existing trunc function update to support appending of dots
 - references updated
 - trimming devfile component name

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@mohammedzee1000
Removing unnessasary file
715bb51 
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@mohammedzee1000
Changing function to vardiac
d0ae864 
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@mohammedzee1000
Copy link
Contributor Author

@girishramnani updated to use vardiac

mik-dass
mik-dass approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 28, 2020
@girishramnani
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 29, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9291f59 into redhat-developer:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-dass mik-dass mik-dass approved these changes

@dharmit dharmit Awaiting requested review from dharmit

@girishramnani girishramnani Awaiting requested review from girishramnani

Assignees

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo catalog list components should truncate long descriptions
7 participants
@mohammedzee1000 @girishramnani @kadel @openshift-ci-robot @openshift-bot @mik-dass @openshift-merge-robot