Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the owner files #4171

Merged
merged 2 commits into from
Oct 30, 2020
Merged

update the owner files #4171

merged 2 commits into from
Oct 30, 2020

Conversation

girishramnani
Copy link
Contributor

@girishramnani girishramnani commented Oct 29, 2020 •
edited

[skip ci]
What does does this PR do / why we need it:
This PR removes the following people from approvers and reviewers list as they are in different teams now.

  • maysunfaisal
  • johnmcollier
  • GeekArthur
  • amitkrout
  • elsony

Also removes cdrage as he is going on leave.

Which issue(s) this PR fixes:

No issue

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

@girishramnani girishramnani requested review from mik-dass and removed request for cdrage and amitkrout October 29, 2020 07:30
@girishramnani girishramnani reopened this Oct 29, 2020
@girishramnani girishramnani changed the title updated the owner files update the owner files Oct 29, 2020
@girishramnani
Copy link
Contributor Author

/retest

kadel
kadel reviewed Oct 29, 2020
View reviewed changes
tests/OWNERS Outdated Show resolved Hide resolved
kadel
kadel reviewed Oct 29, 2020
View reviewed changes
scripts/OWNERS Show resolved Hide resolved
kadel
kadel requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

mik-dass
mik-dass approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@mik-dass mik-dass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 30, 2020
@kadel
Copy link
Member

kadel commented Oct 30, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 30, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 70116e8 into redhat-developer:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel requested changes

@mik-dass mik-dass mik-dass approved these changes

Assignees

@kadel kadel

@mik-dass mik-dass

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@girishramnani @kadel @openshift-ci-robot @openshift-bot @mik-dass @openshift-merge-robot