Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting configure-installer-test-cluster into a library. #4194

Merged

Conversation

mohammedzee1000
Copy link
Contributor

@mohammedzee1000 mohammedzee1000 commented Nov 5, 2020

Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com

#4199

/kind code-refactoring

What does does this PR do / why we need it:
Splits the script into a library that could be used individually.

PR acceptance criteria:

  • Nothing major breaks in the behavior of the scripts
  • We have lesser scripts to maintain
  • I have read the test guidelines

How to test changes / Special notes to the reviewer:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 5, 2020
@mohammedzee1000
Copy link
Contributor Author

/retest

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #4194 (e15e748) into master (fce3c77) will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
- Coverage   42.57%   42.23%   -0.35%     
==========================================
  Files         156      155       -1     
  Lines       13258    13204      -54     
==========================================
- Hits         5645     5577      -68     
- Misses       7012     7020       +8     
- Partials      601      607       +6     
Impacted Files Coverage Δ
pkg/kclient/volumes.go 89.36% <0.00%> (-8.32%) ⬇️
...g/devfile/adapters/kubernetes/component/adapter.go 31.11% <0.00%> (-6.43%) ⬇️
pkg/devfile/adapters/kubernetes/utils/utils.go 80.66% <0.00%> (-0.36%) ⬇️
pkg/url/url.go 73.41% <0.00%> (-0.23%) ⬇️
pkg/catalog/catalog.go 50.55% <0.00%> (ø)
pkg/kclient/supervisord.go 0.00% <0.00%> (ø)
pkg/testingutil/devfile.go 0.00% <0.00%> (ø)
pkg/devfile/adapters/docker/utils/utils.go 85.13% <0.00%> (ø)
pkg/devfile/validate/generic/components.go 100.00% <0.00%> (ø)
pkg/devfile/adapters/docker/component/utils.go 68.69% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce3c77...8e9131c. Read the comment docs.

@mohammedzee1000
Copy link
Contributor Author

/refresh

@rnapoles-rh
Copy link
Contributor

rnapoles-rh commented Nov 10, 2020

setupfirstprojectandvalidate() {
    # Setup project
    oc new-project myproject
    sleep 4
    oc version
    # Project list
    oc projects

@mohammedzee1000 project is setup but there is no validation that commands were successful
Other than that it LGTM

@dharmit
Copy link
Member

dharmit commented Nov 18, 2020

Is this ready for review or is still WIP?

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
…atter

Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
@mohammedzee1000
Copy link
Contributor Author

/test v4.5-integration-e2e

@mohammedzee1000 mohammedzee1000 changed the title WIP Splitting configure-installer-test-cluster into a library. Splitting configure-installer-test-cluster into a library. Nov 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Nov 24, 2020
@girishramnani
Copy link
Contributor

Like the readability
/approve
/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Nov 24, 2020
@rnapoles-rh
Copy link
Contributor

/lgtm

@openshift-merge-robot openshift-merge-robot merged commit c941d69 into redhat-developer:master Nov 24, 2020
@mohammedzee1000 mohammedzee1000 deleted the script_lib branch November 25, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants