-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting configure-installer-test-cluster into a library. #4194
Splitting configure-installer-test-cluster into a library. #4194
Conversation
/retest |
Codecov Report
@@ Coverage Diff @@
## master #4194 +/- ##
==========================================
- Coverage 42.57% 42.23% -0.35%
==========================================
Files 156 155 -1
Lines 13258 13204 -54
==========================================
- Hits 5645 5577 -68
- Misses 7012 7020 +8
- Partials 601 607 +6
Continue to review full report at Codecov.
|
/refresh |
@mohammedzee1000 project is setup but there is no validation that commands were successful |
e15e748
to
8e9131c
Compare
Is this ready for review or is still WIP? |
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
a8b9b0d
to
628298f
Compare
Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
…atter Signed-off-by: Mohammed Zeeshan Ahmed <mohammed.zee1000@gmail.com>
/test v4.5-integration-e2e |
Like the readability |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: girishramnani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Mohammed Zeeshan Ahmed mohammed.zee1000@gmail.com
#4199
/kind code-refactoring
What does does this PR do / why we need it:
Splits the script into a library that could be used individually.
PR acceptance criteria:
How to test changes / Special notes to the reviewer: