Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configure-installer-tests-cluster-s390x to support nodejs12 e2e test #4215

Merged

Conversation

zhengxiaomei123
Copy link
Contributor

@zhengxiaomei123 zhengxiaomei123 commented Nov 13, 2020

What type of PR is this?
/kind bug
/kind feature
What does does this PR do / why we need it:
Make conformance with PR #4070
Which issue(s) this PR fixes:

Fixes #4016

PR acceptance criteria:

How to test changes / Special notes to the reviewer:
Latest nodejs image on 4.6 should work fine for odo

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation labels Nov 13, 2020
@zhengxiaomei123
Copy link
Contributor Author

/area system-pz

@openshift-ci-robot openshift-ci-robot added the area/System-PZ Issues related to IBM System Z and System P label Nov 13, 2020
@kadel
Copy link
Member

kadel commented Nov 13, 2020

/approve
/retest

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 13, 2020
@rnapoles-rh
Copy link
Contributor

/LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 13, 2020
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #4215 (f122549) into master (6366fa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4215   +/-   ##
=======================================
  Coverage   42.56%   42.56%           
=======================================
  Files         156      156           
  Lines       13266    13266           
=======================================
  Hits         5647     5647           
  Misses       7017     7017           
  Partials      602      602           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6366fa8...f122549. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/System-PZ Issues related to IBM System Z and System P kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo create --s2i flag shows Warning message on 4.6 cluster
5 participants